resolv: Fix incorrect variable used in ares_parse_txt_reply() error c…#8791
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in src/resolv/async_resolv.c where the return value of ares_parse_txt_reply (ret) was not being checked, and instead, the callback's status parameter was incorrectly evaluated. The code has been corrected to check ret for success. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
alexey-tikhonov
approved these changes
Jun 9, 2026
Member
|
Thank you, ACK. |
…heck Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Alejandro López <[email protected]>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In src/resolv/async_resolv.c, the error handling for ares_parse_txt_reply() checks the wrong variable. After calling ares_parse_txt_reply(), the result is stored in ret, but the code incorrectly checks status
(a previously used variable) instead.