Skip to content

Makefile: krb5 plugins: don't export internal symbols#8754

Merged
alexey-tikhonov merged 1 commit into
SSSD:masterfrom
alexey-tikhonov:krb5-plugins-symbols
Jun 1, 2026
Merged

Makefile: krb5 plugins: don't export internal symbols#8754
alexey-tikhonov merged 1 commit into
SSSD:masterfrom
alexey-tikhonov:krb5-plugins-symbols

Conversation

@alexey-tikhonov

Copy link
Copy Markdown
Member

No description provided.

@alexey-tikhonov alexey-tikhonov added Trivial A single reviewer is sufficient to review the Pull Request backport-to-sssd-2-13 labels Jun 1, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates Makefile.am to restrict the exported symbols for the sssd_krb5_idp_plugin and sssd_krb5_passkey_plugin plugins by adding the -export-symbols-regex LDFLAGS. I have no feedback to provide.

@alexey-tikhonov
alexey-tikhonov marked this pull request as ready for review June 1, 2026 11:40
@sssd-bot

sssd-bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

The pull request was accepted by @alexey-tikhonov with the following PR CI status:


🟢 CodeQL (success)
🟢 osh-diff-scan:fedora-rawhide-x86_64:upstream (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 testing-farm:fedora-43-x86_64:upstream (success)
🟢 testing-farm:fedora-44-x86_64:centos-stream-10 (success)
🟢 testing-farm:fedora-44-x86_64:upstream (success)
🔴 testing-farm:fedora-rawhide-x86_64:upstream (failure)
🟢 Analyze (target) / cppcheck (success)
🟢 Build / freebsd (success)
🟢 Build / make-distcheck (success)
🟢 ci / intgcheck (centos-10) (success)
🟢 ci / intgcheck (fedora-43) (success)
🟢 ci / intgcheck (fedora-44) (success)
🟢 ci / intgcheck (fedora-45) (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-10) (success)
🟢 ci / system (fedora-43) (success)
🔴 ci / system (fedora-44) (failure)
🔴 ci / system (fedora-45) (failure)
➖ Coverity scan / coverity (skipped)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot
sssd-bot force-pushed the krb5-plugins-symbols branch from 3ae5d85 to a8f39ad Compare June 1, 2026 13:04
@alexey-tikhonov
alexey-tikhonov merged commit 9adeb27 into SSSD:master Jun 1, 2026
10 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted backport-to-sssd-2-13 Trivial A single reviewer is sufficient to review the Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants