Tests: Update LdapOperations to fail on bind immediately#8740
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the LDAP initialization in the test utilities to correctly use the configured self.uri (which includes the port if specified) instead of the raw uri. It also adds error handling to raise an LdapException if the LDAP bind operation returns an error tuple. There are no review comments to address, and I have no additional feedback to provide.
jakub-vavra-cz
added
Waiting for review
Tests
Trivial
Contributor
|
Testing with this looks good: |
Contributor
|
/packit test |
Contributor
|
/packit copr-build |
spoore1
approved these changes
May 28, 2026
spoore1
left a comment
spoore1
left a comment
Contributor
There was a problem hiding this comment.
LGTM. test failures are system tests not multihost tests. The TestingFarm failures are also system tests and not related.
Co-authored-by: Cursor <[email protected]> Reviewed-by: Scott Poore <[email protected]>
Contributor
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LdapOperations.__init__when LDAP bind fails, raisingLdapExceptioninstead of keeping a tuple inself.connself.uriso optional custom port values are honored'tuple' object has no attribute 'modify_s'and surface the real bind problem early