Skip to content

Fix: sss_analyze.py modified to print correct command in usage field#8723

Merged
alexey-tikhonov merged 1 commit into
SSSD:masterfrom
asakure:sssctl_analyze_help
May 26, 2026
Merged

Fix: sss_analyze.py modified to print correct command in usage field#8723
alexey-tikhonov merged 1 commit into
SSSD:masterfrom
asakure:sssctl_analyze_help

Conversation

@asakure

@asakure asakure commented May 22, 2026

Copy link
Copy Markdown
Contributor

Explanation: This patch will make sure to print correct command i.e. sssctl analyze in usage field on running sssctl analyze --help command avoiding confusion.

Resolves: #8718

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ArgumentParser in src/tools/analyzer/sss_analyze.py to explicitly set the program name to 'sssctl analyze', ensuring that the help output correctly reflects the tool's invocation. I have no feedback to provide as there were no review comments.

@justin-stephenson justin-stephenson self-assigned this May 26, 2026
@alexey-tikhonov alexey-tikhonov added the Trivial A single reviewer is sufficient to review the Pull Request label May 26, 2026
Explanation: This patch will make sure to print correct command on
running 'sssctl analyze --help' command avoiding confusion.

Resolves: SSSD#8718
Reviewed-by: Justin Stephenson <[email protected]>
@sssd-bot

Copy link
Copy Markdown
Contributor

The pull request was accepted by @justin-stephenson with the following PR CI status:


🟢 CodeQL (success)
🟢 osh-diff-scan:fedora-rawhide-x86_64:upstream (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 Analyze (target) / cppcheck (success)
🟢 Build / freebsd (success)
🟢 Build / make-distcheck (success)
🟢 ci / intgcheck (centos-10) (success)
🟢 ci / intgcheck (fedora-42) (success)
🟢 ci / intgcheck (fedora-43) (success)
🟢 ci / intgcheck (fedora-44) (success)
🟢 ci / intgcheck (fedora-45) (success)
🟢 ci / prepare (success)
⚪ ci / system (centos-10) (cancelled)
🟢 ci / system (fedora-42) (success)
🟢 ci / system (fedora-43) (success)
🔴 ci / system (fedora-44) (failure)
🔴 ci / system (fedora-45) (failure)
➖ Coverity scan / coverity (skipped)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted backport-to-sssd-2-9 backport-to-sssd-2-13 Trivial A single reviewer is sufficient to review the Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'sssctl analyze --help' shows incorrect command 'sss_analyze' in usage field

4 participants