tests: Clarify approx match filter#8714
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds explanatory comments to the LDAP access control system tests, detailing how different providers (AD, Samba, and 389ds) handle approximate match filters. A review comment identifies a potential logical inconsistency in the test logic: if Samba rejects the approximate match filter with an error as described in the new comments, the assertion that 'user1' can successfully log in may be incorrect, as the entire access check search would likely fail.
justin-stephenson
force-pushed
the
approx_match_comment
branch
from
May 18, 2026 17:17
0d6aef8 to
a11db77
Compare
alexey-tikhonov
added
the
Trivial
thalman
approved these changes
May 25, 2026
thalman
left a comment
thalman
left a comment
Contributor
There was a problem hiding this comment.
The comment is correct, thanks for update
Reviewed-by: Tomáš Halman <[email protected]>
Contributor
sssd-bot
force-pushed
the
approx_match_comment
branch
from
May 25, 2026 12:55
a11db77 to
1af5130
Compare
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debugging this test for an unrelated issue (new failover) lead to several questions about 'approximate match' filter, adding some comments to make it more clear after some investigation.