Skip to content

[autobackport: sssd-2-13] sdap: Reduce log level when get_naming_context() fails#8699

Merged
alexey-tikhonov merged 1 commit into
SSSD:sssd-2-13from
sssd-bot:SSSD-sssd-backport-pr8697-to-sssd-2-13
May 11, 2026
Merged

[autobackport: sssd-2-13] sdap: Reduce log level when get_naming_context() fails#8699
alexey-tikhonov merged 1 commit into
SSSD:sssd-2-13from
sssd-bot:SSSD-sssd-backport-pr8697-to-sssd-2-13

Conversation

@sssd-bot

Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#8697 sdap: Reduce log level when get_naming_context() fails to branch sssd-2-13, created by @scabrero.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot [email protected]:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8697-to-sssd-2-13
git checkout SSSD-sssd-backport-pr8697-to-sssd-2-13
git push sssd-bot SSSD-sssd-backport-pr8697-to-sssd-2-13 --force

Original commits
edf4a0f - sdap: Reduce log level when get_naming_context() fails

Backported commits

  • 3d94983 - sdap: Reduce log level when get_naming_context() fails

Original Pull Request Body

When a plain LDAP server hosts multiple naming contexts but there is no defaultNamingContext in the rootdse, the following message is logged periodically:

[be[LDAP]] [sdap_set_config_options_with_rootdse] (0x0020): get_naming_context failed.

The message is logged at SSSDBG_CRIT_FAILURE level, which seems too high for a non-fatal failure:

        if (sdom->naming_context == NULL) {
            DEBUG(SSSDBG_CRIT_FAILURE, "get_naming_context failed.\n");

            /* This has to be non-fatal, since some servers offer
             * multiple namingContexts entries. We will just
             * add NULL checks for the search bases in the lookups.
             */
            ret = EOK;
            goto done;
        }

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request downgrades the log level from SSSDBG_CRIT_FAILURE to SSSDBG_MINOR_FAILURE in src/providers/ldap/sdap.c when get_naming_context fails, reflecting that this failure is non-fatal. I have no feedback to provide as there were no review comments.

@alexey-tikhonov
alexey-tikhonov removed the request for review from justin-stephenson May 11, 2026 19:32
@alexey-tikhonov alexey-tikhonov added no-backport This should go to target branch only. Accepted labels May 11, 2026
Signed-off-by: Samuel Cabrero <[email protected]>
Reviewed-by: Alexey Tikhonov <[email protected]>
Reviewed-by: Justin Stephenson <[email protected]>
(cherry picked from commit edf4a0f)
@sssd-bot

Copy link
Copy Markdown
Contributor Author

The pull request was accepted by @alexey-tikhonov with the following PR CI status:


🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 Build / freebsd (success)
🟢 Build / make-distcheck (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot
sssd-bot force-pushed the SSSD-sssd-backport-pr8697-to-sssd-2-13 branch from 3d94983 to 78e8cd5 Compare May 11, 2026 20:04
@alexey-tikhonov
alexey-tikhonov merged commit 9826dca into SSSD:sssd-2-13 May 11, 2026
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted no-backport This should go to target branch only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants