sdap: Reduce log level when get_naming_context() fails#8697
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the logging level in src/providers/ldap/sdap.c from SSSDBG_CRIT_FAILURE to SSSDBG_MINOR_FAILURE when get_naming_context fails. This change correctly reflects that the failure is non-fatal, as indicated by the existing code comments. There were no review comments provided for this pull request, so I have no additional feedback to offer.
alexey-tikhonov
approved these changes
May 11, 2026
justin-stephenson
approved these changes
May 11, 2026
Signed-off-by: Samuel Cabrero <[email protected]> Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Justin Stephenson <[email protected]>
Contributor
sssd-bot
force-pushed
the
scabrero-nc-log-lvl
branch
from
May 11, 2026 19:25
7227464 to
c8dbd8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a plain LDAP server hosts multiple naming contexts but there is no
defaultNamingContextin the rootdse, the following message is logged periodically:[be[LDAP]] [sdap_set_config_options_with_rootdse] (0x0020): get_naming_context failed.The message is logged at
SSSDBG_CRIT_FAILURElevel, which seems too high for a non-fatal failure: