Skip to content

[autobackport: sssd-2-13] tests: avoid fixed sleep in KCM timestamp refresh test#8694

Merged
jakub-vavra-cz merged 1 commit into
SSSD:sssd-2-13from
sssd-bot:SSSD-sssd-backport-pr8678-to-sssd-2-13
May 12, 2026
Merged

[autobackport: sssd-2-13] tests: avoid fixed sleep in KCM timestamp refresh test#8694
jakub-vavra-cz merged 1 commit into
SSSD:sssd-2-13from
sssd-bot:SSSD-sssd-backport-pr8678-to-sssd-2-13

Conversation

@sssd-bot

@sssd-bot sssd-bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#8678 tests: avoid fixed sleep in KCM timestamp refresh test to branch sssd-2-13, created by @jakub-vavra-cz.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot [email protected]:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8678-to-sssd-2-13
git checkout SSSD-sssd-backport-pr8678-to-sssd-2-13
git push sssd-bot SSSD-sssd-backport-pr8678-to-sssd-2-13 --force

Original commits
1b802f4 - Tests: Fix test_refresh_contain_timestamp

Backported commits

  • c0e5b2c - Tests: Fix test_refresh_contain_timestamp

Original Pull Request Body

Summary

  • Replace fixed 65s sleep in KCM refresh test with bounded polling loop.
  • Retry grep for the LDAP search log entry with 10s intervals up to 120s total.
  • Keep assertion logic unchanged while reducing timing flakiness.

@sssd-bot
sssd-bot requested a review from madhuriupadhye May 11, 2026 12:41
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 11, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates src/tests/multihost/alltests/test_kcm.py by reorganizing imports and replacing a static sleep with a polling loop to verify log entries, which enhances test stability. There are no review comments, and I have no feedback to provide.

@madhuriupadhye madhuriupadhye added Accepted Tests Trivial A single reviewer is sufficient to review the Pull Request labels May 12, 2026
@jakub-vavra-cz @sssd-bot
Tests: Fix test_refresh_contain_timestamp
8235ed5 
Reviewed-by: Madhuri Upadhye <[email protected]>
(cherry picked from commit 1b802f4)
@sssd-bot

sssd-bot commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

The pull request was accepted by @madhuriupadhye with the following PR CI status:

🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 Build / freebsd (success)
🟢 Build / make-distcheck (success)

There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot
sssd-bot force-pushed the SSSD-sssd-backport-pr8678-to-sssd-2-13 branch from c0e5b2c to 8235ed5 Compare May 12, 2026 06:32
@jakub-vavra-cz
jakub-vavra-cz merged commit a4bbfb4 into SSSD:sssd-2-13 May 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@madhuriupadhye madhuriupadhye madhuriupadhye approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@madhuriupadhye madhuriupadhye

Labels

Accepted Tests Trivial A single reviewer is sufficient to review the Pull Request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sssd-bot @madhuriupadhye @jakub-vavra-cz