tests: avoid fixed sleep in KCM timestamp refresh test#8678
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reorganizes imports and replaces a static sleep with a polling loop in test_kcm.py to improve test reliability. Feedback highlights a potential false positive where the test could pass if the log entry is never found, suggesting an explicit assertion on the command's return code.
jakub-vavra-cz
added
Waiting for review
Tests
Trivial
jakub-vavra-cz
force-pushed
the
kcm_timestamp
branch
from
May 7, 2026 09:02
6480acd to
bfd93b3
Compare
madhuriupadhye
approved these changes
May 11, 2026
Reviewed-by: Madhuri Upadhye <[email protected]>
Contributor
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary