sdap: let callers mark SSSD as offline if kinit fails#8675
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the error handling logic in sdap_cli_resolve_and_connect_kinit_done within src/providers/ldap/sdap_async_connection.c. When a TGT cannot be obtained, the implementation now explicitly sets state->can_retry to false and returns EIO instead of EACCES. I have no feedback to provide as there were no review comments to evaluate.
pbrezina
force-pushed
the
offline
branch
3 times, most recently
from
May 6, 2026 17:44
4a6429d to
1849606
Compare
alexey-tikhonov
self-requested a review
May 7, 2026 12:41
alexey-tikhonov
added
backport-to-sssd-2-13
coverity
Member
Author
|
User confirmed the patch solves the issue. |
Member
|
Note: Covscan is clean. |
Member
|
@pbrezina, any idea why it fails tons of tests on F45 and C10S? |
alexey-tikhonov
approved these changes
May 12, 2026
Member
|
ACK |
sumit-bose
approved these changes
May 13, 2026
sumit-bose
left a comment
sumit-bose
left a comment
Contributor
There was a problem hiding this comment.
Hi,
thank you for the fix and adding the tests, ACK.
bye,
Sumit
The callers expected that ret == EIO and can_retry == false to bring SSSD to an offline state. Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Sumit Bose <[email protected]>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The callers expected that ret == EIO and can_retry == false to bring
SSSD to an offline state.