KRB5: read keytab copy in offline mode too#8671
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the privileged_krb5_setup function in krb5_child.c to allow keytab setup even when offline, while adding a guard to skip FAST configuration in offline mode. Feedback suggests that skipping FAST setup entirely when offline could lead to security issues or authentication failures if the process transitions to online mode later, as the FAST options would not be properly initialized.
sumit-bose
approved these changes
May 8, 2026
sumit-bose
left a comment
sumit-bose
left a comment
Contributor
There was a problem hiding this comment.
Hi,
thank you for the fix to solve the regression, ACK.
Nevertheless it might be good to rethink the role of krb5_child if the SSSD backend is offline.
bye,
Sumit
sumit-bose
added
coverity
Contributor
|
Coverity was green. |
The process can transition from offline pre-auth to online auth within the same invocation. Reviewed-by: Iker Pedrosa <[email protected]> Reviewed-by: Sumit Bose <[email protected]>
Contributor
sssd-bot
force-pushed
the
read-keytab-offline
branch
from
May 11, 2026 06:38
f9effbb to
3c569bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The process can transition from offline pre-auth to online auth within the same invocation.