[autobackport: sssd-2-13] tests: poll for KCM TGT renewal instead of fixed sleep#8660
Merged
alexey-tikhonov merged 1 commit intoApr 28, 2026
Conversation
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
alexey-tikhonov
approved these changes
Apr 28, 2026
test_kcm__tgt_renewal_updates_ticket_as_configured no longer uses a fixed sleep(5) and flaky retries. The test now polls klist every 0.5s and asserts renewal by checking that TGT start or end time advances, with a detailed failure message that prints both initial and last timestamps. To match KCM renewal behavior (renewal only starts after roughly half the ticket lifetime), the test uses a short renewable ticket (-r 5s -l 5s) and a bounded polling window (9s) so it stays fast while still waiting long enough for renewal to be attempted. Also removed the temporary CI comment and the flaky marker from this test. Assited by: Cursor(Claude Opus 4.6) Signed-off-by: Madhuri Upadhye <[email protected]> Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Scott Poore <[email protected]> (cherry picked from commit 233db39)
Contributor
Author
|
The pull request was accepted by @alexey-tikhonov with the following PR CI status: 🟡 rpm-build:centos-stream-10-x86_64:upstream (in_progress) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
sssd-bot
force-pushed
the
SSSD-sssd-backport-pr8650-to-sssd-2-13
branch
from
April 28, 2026 13:20
ca144c0 to
36682c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of PR#8650 tests: poll for KCM TGT renewal instead of fixed sleep to branch sssd-2-13, created by @madhuriupadhye.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
233db39 - tests: poll for KCM TGT renewal instead of fixed sleep
Backported commits
Original Pull Request Body
test_kcm__tgt_renewal_updates_ticket_as_configured no longer uses a fixed sleep(5) and flaky retries.
The test now polls klist every 0.5s and asserts renewal by checking that TGT start or end time advances, with a detailed failure message that prints both initial and last timestamps.
To match KCM renewal behavior (renewal only starts after roughly half the ticket lifetime), the test uses a short renewable ticket (-r 5s -l 5s) and a bounded polling window (9s) so it stays fast while still waiting long enough for renewal to be attempted.
Also removed the temporary CI comment and the flaky marker from this test.