Skip to content

[autobackport: sssd-2-9] tests: mark KCM TGT renewal test as flaky#8642

Merged
alexey-tikhonov merged 1 commit into
SSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8638-to-sssd-2-9
Apr 24, 2026
Merged

[autobackport: sssd-2-9] tests: mark KCM TGT renewal test as flaky#8642
alexey-tikhonov merged 1 commit into
SSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8638-to-sssd-2-9

Conversation

@sssd-bot

Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#8638 tests: mark KCM TGT renewal test as flaky to branch sssd-2-9, created by @madhuriupadhye.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot [email protected]:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8638-to-sssd-2-9
git checkout SSSD-sssd-backport-pr8638-to-sssd-2-9
git push sssd-bot SSSD-sssd-backport-pr8638-to-sssd-2-9 --force

Original commits
32dedfb - tests: mark KCM TGT renewal test as flaky

Backported commits

  • 4f74cfe - tests: mark KCM TGT renewal test as flaky

Original Pull Request Body

Add @pytest.mark.flaky(max_runs=3)
using the existing flaky marker

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the system tests for KCM by adding the @pytest.mark.flaky(reruns=3) decorator to a test case in src/tests/system/tests/test_kcm.py. This change allows the test to be retried up to three times in the event of a failure, which is typically used to mitigate impact from intermittent or unstable test environments. I have no feedback to provide as there were no review comments to evaluate.

@alexey-tikhonov alexey-tikhonov added the no-backport This should go to target branch only. label Apr 24, 2026
@alexey-tikhonov
alexey-tikhonov removed the request for review from jakub-vavra-cz April 24, 2026 15:40
@alexey-tikhonov alexey-tikhonov self-assigned this Apr 24, 2026
Add @pytest.mark.flaky(reruns=3)
using the existing flaky marker

Signed-off-by: Madhuri Upadhye <[email protected]>
Reviewed-by: Alexey Tikhonov <[email protected]>
Reviewed-by: Jakub Vávra <[email protected]>
(cherry picked from commit 32dedfb)
@sssd-bot

Copy link
Copy Markdown
Contributor Author

The pull request was accepted by @alexey-tikhonov with the following PR CI status:


🟢 CodeQL (success)
🟢 rpm-build:centos-stream-9-x86_64:upstream (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-9) (success)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot
sssd-bot force-pushed the SSSD-sssd-backport-pr8638-to-sssd-2-9 branch from 4f74cfe to ec251b9 Compare April 24, 2026 15:42
@alexey-tikhonov
alexey-tikhonov merged commit df360cd into SSSD:sssd-2-9 Apr 24, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted no-backport This should go to target branch only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants