Skip to content

tests: mark KCM TGT renewal test as flaky#8638

Merged
alexey-tikhonov merged 1 commit into
SSSD:masterfrom
madhuriupadhye:kcm_rerun
Apr 24, 2026
Merged

tests: mark KCM TGT renewal test as flaky#8638
alexey-tikhonov merged 1 commit into
SSSD:masterfrom
madhuriupadhye:kcm_rerun

Conversation

@madhuriupadhye

Copy link
Copy Markdown
Contributor

Add @pytest.mark.flaky(max_runs=3)
using the existing flaky marker

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a flaky marker to a KCM system test to handle intermittent failures. A review comment points out that the 'max_runs' parameter is incorrect for the project's test environment and suggests using 'reruns' instead to ensure the retry mechanism functions as intended.

Comment thread src/tests/system/tests/test_kcm.py Outdated
Add @pytest.mark.flaky(reruns=3)
using the existing flaky marker

Signed-off-by: Madhuri Upadhye <[email protected]>
Reviewed-by: Alexey Tikhonov <[email protected]>
Reviewed-by: Jakub Vávra <[email protected]>
@sssd-bot

Copy link
Copy Markdown
Contributor

The pull request was accepted by @alexey-tikhonov with the following PR CI status:


🟢 CodeQL (success)
🟢 osh-diff-scan:fedora-rawhide-x86_64:upstream (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 Analyze (target) / cppcheck (success)
🟢 ci / intgcheck (centos-10) (success)
🟢 ci / intgcheck (fedora-42) (success)
🟢 ci / intgcheck (fedora-43) (success)
🟢 ci / intgcheck (fedora-44) (success)
🟢 ci / intgcheck (fedora-45) (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-10) (success)
🟢 ci / system (fedora-42) (success)
🟢 ci / system (fedora-43) (success)
🟢 ci / system (fedora-44) (success)
🟢 ci / system (fedora-45) (success)
➖ Coverity scan / coverity (skipped)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants