Skip to content

dp_target_id.c: Fix typo "lenght" -> "length"#8621

Merged
alexey-tikhonov merged 1 commit into
SSSD:masterfrom
arrowd:typo
Apr 22, 2026
Merged

dp_target_id.c: Fix typo "lenght" -> "length"#8621
alexey-tikhonov merged 1 commit into
SSSD:masterfrom
arrowd:typo

Conversation

@arrowd

@arrowd arrowd commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Closes #8590

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a typo in src/providers/data_provider/dp_target_id.c by renaming the struct member lenght to length within the check_and_parse_filter and check_and_parse_acct_domain_filter functions. I have no feedback to provide.

@alexey-tikhonov

Copy link
Copy Markdown
Member

Commit message failed to grasp a mistype being fixed :)

We also use 'Resolves:' , not 'Closes' (release notes automation relies on this).

@arrowd arrowd changed the title dp_target_id.c: Fix typo "length" -> "length" dp_target_id.c: Fix typo "lenght" -> "length" Apr 21, 2026
@alexey-tikhonov alexey-tikhonov added the coverity Trigger a coverity scan label Apr 21, 2026
@alexey-tikhonov alexey-tikhonov self-assigned this Apr 21, 2026
@alexey-tikhonov alexey-tikhonov added Trivial A single reviewer is sufficient to review the Pull Request Accepted and removed coverity Trigger a coverity scan labels Apr 21, 2026
@sssd-bot

Copy link
Copy Markdown
Contributor

The pull request was accepted by @alexey-tikhonov with the following PR CI status:


🟢 CodeQL (success)
🟢 osh-diff-scan:fedora-rawhide-x86_64:upstream (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 Analyze (target) / cppcheck (success)
🟢 Build / freebsd (success)
🟢 Build / make-distcheck (success)
🟢 ci / intgcheck (centos-10) (success)
🟢 ci / intgcheck (fedora-42) (success)
🟢 ci / intgcheck (fedora-43) (success)
🟢 ci / intgcheck (fedora-44) (success)
🟢 ci / intgcheck (fedora-45) (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-10) (success)
🟢 ci / system (fedora-42) (success)
🟢 ci / system (fedora-43) (success)
🟢 ci / system (fedora-44) (success)
🟢 ci / system (fedora-45) (success)
➖ Coverity scan / coverity (skipped)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@alexey-tikhonov
alexey-tikhonov merged commit ba4353f into SSSD:master Apr 22, 2026
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted backport-to-sssd-2-9 Trivial A single reviewer is sufficient to review the Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

typo "lenght" within src/providers/data_provider/dp_target_id.c

3 participants