[autobackport: sssd-2-9] Add missing include#8603
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the inclusion of the config.h header file to src/sss_client/autofs/sss_autofs.c, which is a standard practice in C projects to ensure configuration macros are defined before other headers. I have no feedback to provide as there are no review comments.
alexey-tikhonov
added
no-backport
Original patch f3af8c8 didn't include "config.h" that provides `HAVE_PTHREAD_EXT` It works in some branches accidentally because of transitive include via "sss_cli.h" but that's fragile (and in some branches "sss_cli.h" doesn't include "config.h") Reviewed-by: Tomáš Halman <[email protected]> (cherry picked from commit a809b92)
|
The pull request was accepted by @thalman with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
20cb0d2 to
4b4ce50
Compare
3 participants
This is an automatic backport of PR#8602 Add missing include to branch sssd-2-9, created by @alexey-tikhonov.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
a809b92 - Add missing include
Backported commits
Original Pull Request Body
Original patch f3af8c8 didn't include "config.h" that provides
HAVE_PTHREAD_EXTIt works in some branches accidentally because of transitive include via "sss_cli.h" but that's fragile (and in some branches "sss_cli.h" doesn't include "config.h")