KCM: fix use-after-free in kcm_read_options()#8592
Merged
Conversation
alexey-tikhonov
added
backport-to-sssd-2-9
Trivial
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the kcm_read_options function in src/responder/kcm/kcm_renew.c to use talloc_steal when assigning the renewal interval. This ensures that the memory ownership of renew_intv is correctly transferred to the provided memory context, preventing potential memory management issues. I have no feedback to provide.
sumit-bose
approved these changes
Apr 13, 2026
sumit-bose
left a comment
sumit-bose
left a comment
Contributor
There was a problem hiding this comment.
Hi,
thank you for the fix, ACK.
bye,
Sumit
The `renew_intv` string was allocated under tmp_ctx but not re-linked to mem_ctx before tmp_ctx was freed. Assisted-By: Claude Code (Opus 4.6) Reviewed-by: Sumit Bose <[email protected]>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
renew_intvstring was allocated under tmp_ctx but not re-linked to mem_ctx before tmp_ctx was freed.Assisted-By: Claude Code (Opus 4.6)
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2457467