Skip to content

[autobackport: sssd-2-9] Fix spelling in AD provider code comments#8589

Merged
danlavu merged 1 commit into
SSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8565-to-sssd-2-9
Apr 14, 2026
Merged

[autobackport: sssd-2-9] Fix spelling in AD provider code comments#8589
danlavu merged 1 commit into
SSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8565-to-sssd-2-9

Conversation

@sssd-bot

@sssd-bot sssd-bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#8565 Fix spelling in AD provider code comments to branch sssd-2-9, created by @striker314.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot [email protected]:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8565-to-sssd-2-9
git checkout SSSD-sssd-backport-pr8565-to-sssd-2-9
git push sssd-bot SSSD-sssd-backport-pr8565-to-sssd-2-9 --force

Original commits
58cc4d2 - Fix spelling in AD provider code comments

Backported commits

  • 8a5a734 - Fix spelling in AD provider code comments

Original Pull Request Body

Fixed some simple spelling errors within the AD providers code comments.

@sssd-bot
sssd-bot requested a review from danlavu April 10, 2026 15:52
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 10, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects several typos in comments and debug log messages across various files in the Active Directory provider, including ad_common.c, ad_common.h, ad_gpo.c, ad_gpo_child.c, ad_gpo_child_utils.c, ad_id.c, and ad_subdomains.c. I have no feedback to provide as the changes correctly address the spelling errors.

@danlavu danlavu added no-backport This should go to target branch only. Accepted labels Apr 14, 2026
@striker314 @sssd-bot
Fix spelling in AD provider code comments
498321d 
Reviewed-by: Dan Lavu <[email protected]>
(cherry picked from commit 58cc4d2)
@sssd-bot

sssd-bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

The pull request was accepted by @danlavu with the following PR CI status:

🟢 CodeQL (success)
🟢 rpm-build:centos-stream-9-x86_64:upstream (success)
🔴 Build / make-distcheck (failure)
🟢 ci / prepare (success)
🟢 ci / system (centos-9) (success)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)

There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@danlavu danlavu added the Trivial A single reviewer is sufficient to review the Pull Request label Apr 14, 2026
@sssd-bot
sssd-bot force-pushed the SSSD-sssd-backport-pr8565-to-sssd-2-9 branch from 8a5a734 to 498321d Compare April 14, 2026 02:19
@danlavu
danlavu merged commit d61053e into SSSD:sssd-2-9 Apr 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danlavu danlavu danlavu approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@danlavu danlavu

Labels

Accepted no-backport This should go to target branch only. Trivial A single reviewer is sufficient to review the Pull Request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sssd-bot @danlavu @striker314