Skip to content

Add support for Plasma Login Manager as a supported PAM service#8506

Merged
alexey-tikhonov merged 1 commit into
SSSD:masterfrom
Conan-Kudo:plasmalogin
Mar 10, 2026
Merged

Add support for Plasma Login Manager as a supported PAM service#8506
alexey-tikhonov merged 1 commit into
SSSD:masterfrom
Conan-Kudo:plasmalogin

Conversation

@Conan-Kudo

Copy link
Copy Markdown
Contributor

Plasma Login Manager is the new recommended login manager for KDE Plasma, and is used as the login manager for Fedora Linux 44 and higher for KDE Plasma.

Reference: https://fedoraproject.org/wiki/Changes/PlasmaLoginManager

Resolves: #8490

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds support for Plasma Login Manager as a supported PAM service. My review focuses on maintaining alphabetical order in the lists where the new service is added to improve code consistency and maintainability.

Comment thread src/providers/ad/ad_gpo.c Outdated
Comment thread src/providers/ad/ad_gpo.c Outdated
Comment thread src/man/sssd-ad.5.xml
@alexey-tikhonov alexey-tikhonov added the no-backport This should go to target branch only. label Mar 7, 2026
@sumit-bose

Copy link
Copy Markdown
Contributor

Hi,

thank you for the patch. Do you think palsmelogin should be also added to the list of allowed services for Smartcard authentication, see pam_p11_allowed_services in man sssd.conf for details?

bye,
Sumit

@Conan-Kudo

Copy link
Copy Markdown
Contributor Author

Yeah, it should, let me add that to this pull request.

@Conan-Kudo Conan-Kudo changed the title AD GPO: Add support for Plasma Login Manager as a supported PAM service Add support for Plasma Login Manager as a supported PAM service Mar 9, 2026
@Conan-Kudo

Copy link
Copy Markdown
Contributor Author

I've added Plasma Login Manager accordingly.

@sumit-bose sumit-bose left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thank you for the update, ACK.

bye,
Sumit

@alexey-tikhonov alexey-tikhonov added the coverity Trigger a coverity scan label Mar 9, 2026
@alexey-tikhonov alexey-tikhonov added backport-to-sssd-2-12 and removed no-backport This should go to target branch only. coverity Trigger a coverity scan labels Mar 9, 2026
@alexey-tikhonov

Copy link
Copy Markdown
Member

Note: Covscan is green.

@sssd-bot

sssd-bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

The pull request was accepted by @alexey-tikhonov with the following PR CI status:


🟢 CodeQL (success)
🟢 osh-diff-scan:fedora-rawhide-x86_64:upstream (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 Analyze (target) / cppcheck (success)
🟢 Build / freebsd (success)
🟢 Build / make-distcheck (success)
🟢 ci / intgcheck (centos-10) (success)
🟢 ci / intgcheck (fedora-42) (success)
🟢 ci / intgcheck (fedora-43) (success)
🟢 ci / intgcheck (fedora-44) (success)
🟢 ci / intgcheck (fedora-45) (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-10) (success)
🟢 ci / system (fedora-42) (success)
🟢 ci / system (fedora-43) (success)
🟢 ci / system (fedora-44) (success)
🟢 ci / system (fedora-45) (success)
➖ Coverity scan / coverity (skipped)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@alexey-tikhonov

Copy link
Copy Markdown
Member

@Conan-Kudo , could you please set "Maitainers are allow to edit this pull request"? This is required for CI job to set "reveiwed-by" tags in the commit messages:
https://github.com/SSSD/sssd/actions/runs/22871618051/job/66352606747?pr=8506

@Conan-Kudo

Copy link
Copy Markdown
Contributor Author

Done.

Plasma Login Manager is the new recommended login manager for KDE Plasma,
and is used as the login manager for Fedora Linux 44 and higher for KDE
Plasma.

Reference: https://fedoraproject.org/wiki/Changes/PlasmaLoginManager

Resolves: SSSD#8490

Signed-off-by: Neal Gompa <[email protected]>
Reviewed-by: Alexey Tikhonov <[email protected]>
Reviewed-by: Sumit Bose <[email protected]>
@sssd-bot

Copy link
Copy Markdown
Contributor

The pull request was accepted by @alexey-tikhonov with the following PR CI status:


🟢 CodeQL (success)
🟢 osh-diff-scan:fedora-rawhide-x86_64:upstream (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 Analyze (target) / cppcheck (success)
🟢 Build / freebsd (success)
🟢 Build / make-distcheck (success)
🟢 ci / intgcheck (centos-10) (success)
🟢 ci / intgcheck (fedora-42) (success)
🟢 ci / intgcheck (fedora-43) (success)
🟢 ci / intgcheck (fedora-44) (success)
🟢 ci / intgcheck (fedora-45) (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-10) (success)
🟢 ci / system (fedora-42) (success)
🟢 ci / system (fedora-43) (success)
🟢 ci / system (fedora-44) (success)
🟢 ci / system (fedora-45) (success)
➖ Coverity scan / coverity (skipped)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@alexey-tikhonov
alexey-tikhonov merged commit 5df3bff into SSSD:master Mar 10, 2026
2 of 7 checks passed
@Conan-Kudo
Conan-Kudo deleted the plasmalogin branch March 10, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add KDE Plasma Login Manager to ad_gpo_map_interactive and update man page

4 participants