Tests: Add integration tests validating SSSD socket by aborah-sudo · Pull Request #8481 · SSSD/sssd

aborah-sudo · 2026-02-25T06:03:40Z

Add integration tests validating SSSD socket activation behavior for individual responders and mixed socket/traditional configurations.

gemini-code-assist

Code Review

This pull request introduces a new suite of integration tests for SSSD's socket activation feature. The tests validate the lifecycle of individual socket-activated responders and also cover scenarios with a mix of socket-activated and traditional services. The implementation is generally good, but I've identified a high-severity issue in one of the tests where a necessary service restart is missing after configuration changes. This could make the test unreliable. My review includes a specific suggestion to fix this.

jakub-vavra-cz

The code looks pretty nice however we need to separate the autofs cases to standalone ones with autofs in the test name. Autofs is not supported in image mode so we are skipping those tests based on name (see: https://gitlab.cee.redhat.com/sssd/sssd-qe/-/blob/main/test-plan/mh_jobs.yaml#L39) and we would be unable to do that here.

The tests that are not using autofs could be probably switched to topology BareLDAP that do not need nfs and kcm so they could be run on smaller footprint.

jakub-vavra-cz

LGTM.

alexey-tikhonov · 2026-03-25T09:05:25Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a new set of system tests for SSSD socket activation, covering the lifecycle of socket-activated responders (NSS, PAM, SSH, and Autofs) and scenarios involving a mix of socket-activated and traditional services. The review comments point out that in the test_socket__responders__socket_activation_lifecycle_autofs and test_socket__responders__mixed_socket_and_traditional_services_autofs tests, a user user1 is created but not utilized, suggesting its removal to improve test clarity and efficiency.

alexey-tikhonov · 2026-03-25T09:16:16Z

@danlavu, @jakub-vavra-cz, does this need @pytest.mark.importance markers?

alexey-tikhonov · 2026-03-25T09:22:09Z

Would be great to have a 'low importance' test that would test "nss respoder is configured both in 'sssd.conf' and socket activation is enabled" (the latter should refuse to start).

alexey-tikhonov · 2026-03-26T17:57:28Z

'system tests' fail on all platforms.

alexey-tikhonov · 2026-03-26T18:01:40Z

@danlavu, @jakub-vavra-cz, does this need @pytest.mark.importance markers?

By default it will be "medium" importance

I would suggesting selecting one basic test as "medium" or even "high", and remaining as "low".

ack

Looks like this wasn't addressed.

alexey-tikhonov · 2026-03-27T07:48:43Z

F44:

>       assert not client.sssd.svc.is_active(socket_service), f"{socket_responder} service should be inactive initially"
E       AssertionError: nss service should be inactive initially
E       assert not True

F45:

FAILED tests/test_socket.py::test_socket__responders__socket_activation_lifecycle[nss] (ldap) - AssertionError: nss service should be inactive initially
FAILED tests/test_socket.py::test_socket__responders__mixed_socket_and_traditional_services[nss] (ldap) - AssertionError: nss service should be inactive initially

I suspect a race condition: a random system NSS lookup triggers start of socket activation after it is enabled and before it is checked.

alexey-tikhonov · 2026-03-27T10:52:45Z

ACK

@jakub-vavra-cz, please take a look at the updated version.

jakub-vavra-cz

LGTM.

Add integration tests validating SSSD socket activation behavior for individual responders and mixed socket/traditional configurations. Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Jakub Vávra <[email protected]>

sssd-bot · 2026-03-30T14:09:35Z

The pull request was accepted by @alexey-tikhonov with the following PR CI status:

There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

aborah-sudo added Waiting for review Tests backport-to-sssd-2-9 backport-to-sssd-2-10 backport-to-sssd-2-11 backport-to-sssd-2-12 labels Feb 25, 2026

aborah-sudo requested review from alexey-tikhonov and jakub-vavra-cz February 25, 2026 06:04

gemini-code-assist Bot reviewed Feb 25, 2026

View reviewed changes

Comment thread src/tests/system/tests/test_socket.py

aborah-sudo assigned alexey-tikhonov and jakub-vavra-cz Feb 25, 2026

aborah-sudo force-pushed the socket branch 4 times, most recently from d5b5bb0 to 35acf9d Compare February 25, 2026 06:30

aborah-sudo force-pushed the socket branch from 35acf9d to 444c11c Compare March 4, 2026 07:31

jakub-vavra-cz requested changes Mar 4, 2026

View reviewed changes

aborah-sudo force-pushed the socket branch from 444c11c to 6c0f788 Compare March 5, 2026 05:42

aborah-sudo requested a review from jakub-vavra-cz March 5, 2026 05:43

jakub-vavra-cz approved these changes Mar 5, 2026

View reviewed changes

gemini-code-assist Bot reviewed Mar 25, 2026

View reviewed changes

Comment thread src/tests/system/tests/test_socket.py Outdated

Comment thread src/tests/system/tests/test_socket.py Outdated