[autobackport: sssd-2-9] Fix compilation errors#8476
Merged
alexey-tikhonov merged 9 commits intoFeb 24, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is an automatic backport to fix compilation errors. The changes include correcting discarded-qualifiers warnings in several C files by adjusting pointer types for const correctness, which is appropriate. However, critical issues exist in Makefile.am and src/util/sss_python.h where unresolved merge conflicts are present. These conflicts must be resolved before the pull request can be merged.
alexey-tikhonov
force-pushed
the
SSSD-sssd-backport-pr8469-to-sssd-2-9
branch
from
February 23, 2026 15:30
f8c2aed to
6c7aa78
Compare
alexey-tikhonov
marked this pull request as ready for review
February 23, 2026 15:57
Use a separate `const char *dot` variable for the strchr() result on the const input string, keeping the mutable `char *p` for the later iteration over the output buffer. Implementation-By: Claude Code (Opus 4.6) Reviewed-by: Tomáš Halman <[email protected]> (cherry picked from commit 2de3751)
Make rid1 and rid2 `const char *` since they only hold strrchr() results from const input strings and are used for pointer arithmetic. Implementation-By: Claude Code (Opus 4.6) Reviewed-by: Tomáš Halman <[email protected]> (cherry picked from commit 5548493)
Make endptr and end_range `const char *` since they only hold strchr()/strrchr() results from const input strings. Introduce a separate `numendptr` variable for the strtouint32() output parameter. Implementation-By: Claude Code (Opus 4.6) Reviewed-by: Tomáš Halman <[email protected]> (cherry picked from commit ef104b7)
Make sep `const char *` since it only holds a strchr() result from a const input string and is used for pointer arithmetic. Implementation-By: Claude Code (Opus 4.6) Reviewed-by: Tomáš Halman <[email protected]> (cherry picked from commit 086a52e)
Make specdelim and kwdelim `const char *` in parse_sub_filter() and parse_filter() since they only hold strchr() results from const input strings and are used for pointer arithmetic. Implementation-By: Claude Code (Opus 4.6) Reviewed-by: Tomáš Halman <[email protected]> (cherry picked from commit 0f21660)
Make delim in get_type_prefix() and sep in expand_sid() `const char *` since they only hold strchr()/strrchr() results from const input strings and are used for pointer arithmetic and reading. Implementation-By: Claude Code (Opus 4.6) Reviewed-by: Tomáš Halman <[email protected]> (cherry picked from commit 24de2bc)
Make at_sign `const char *` since it only holds a strchr() result from a const input string and is used for reading. Implementation-By: Claude Code (Opus 4.6) Reviewed-by: Tomáš Halman <[email protected]> (cherry picked from commit 68edad9)
Assisted-By: Claude Code (Opus 4.6) Reviewed-by: Tomáš Halman <[email protected]> (cherry picked from commit 9e517f8)
Older Fedora versions still have cmocka < 2.0.0 making it inconvinient to support two interfaces. Reviewed-by: Tomáš Halman <[email protected]> (cherry picked from commit 39db12d)
Contributor
Author
|
The pull request was accepted by @alexey-tikhonov with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
sssd-bot
force-pushed
the
SSSD-sssd-backport-pr8469-to-sssd-2-9
branch
from
February 24, 2026 10:08
6c7aa78 to
d60e7e6
Compare
alexey-tikhonov
added
backport-to-sssd-2-9-4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of PR#8469 Fix compilation errors to branch sssd-2-9, created by @alexey-tikhonov.
Caution
@alexey-tikhonov The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with
CONFLICT!.You can push changes to this pull request
Original commits
2de3751 - UTIL: fix discarded-qualifiers warning in domain_to_basedn()
5548493 - SDAP: fix discarded-qualifiers warning in are_sids_from_same_dom()
ef104b7 - SDAP: fix discarded-qualifiers warnings in sdap_parse_range()
086a52e - SDAP: fix discarded-qualifiers warning in split_extra_attr()
0f21660 - AD: fix discarded-qualifiers warnings in ad_access filter parsing
24de2bc - CERTMAP: fix discarded-qualifiers warnings in sss_certmap.c
68edad9 - KRB5: fix discarded-qualifiers warning in compare_principal_realm()
9e517f8 - Makefile: add missing 'CMOCKA_CFLAGS'
39db12d - BUILD: supress 'deprecated-declarations' error for cmocka tests
54c6340 - BUILD: fix _POSIX_C_SOURCE redefinition with Python 3.14 and glibc 2.41+
Backported commits
Conflicting Files Information (check for deleted and re-added files)
On branch SSSD-sssd-backport-pr8469-to-sssd-2-9
You are currently cherry-picking commit 54c6340.
(fix conflicts and run "git cherry-pick --continue")
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Unmerged paths:
(use "git add ..." to mark resolution)
both modified: src/util/sss_python.h
no changes added to commit (use "git add" and/or "git commit -a")