get_client_cred: Pass correct option level value on FreeBSD#8471
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request correctly introduces a platform-independent way to specify the socket option level for retrieving peer credentials, which is necessary for supporting FreeBSD and macOS. However, the use of SOL_LOCAL for FreeBSD is problematic as it is not a standard macro on that platform and will likely cause compilation errors. The documentation referenced in the code itself suggests using 0 as the level for FreeBSD.
arrowd
force-pushed
the
getsockopt-freebsd-fix
branch
from
February 23, 2026 09:08
dbe335a to
f3e322c
Compare
alexey-tikhonov
approved these changes
Feb 23, 2026
Member
|
Please rebase this and other open PRs (#8469 was merged) |
arrowd
force-pushed
the
getsockopt-freebsd-fix
branch
2 times, most recently
from
February 23, 2026 16:06
26b8813 to
632049a
Compare
Member
|
Could you please rebase again? #8449 was merged. |
arrowd
force-pushed
the
getsockopt-freebsd-fix
branch
from
February 24, 2026 18:24
632049a to
57be285
Compare
alexey-tikhonov
self-requested a review
February 25, 2026 08:19
Member
|
Looks like Line 1037 in c6dc4d7 |
arrowd
force-pushed
the
getsockopt-freebsd-fix
branch
2 times, most recently
from
February 25, 2026 10:44
cd13be0 to
e29efaa
Compare
alexey-tikhonov
approved these changes
Feb 25, 2026
Member
|
ACK |
alexey-tikhonov
added
coverity
Member
|
Note: Covscan is green. |
…ress() and get_client_cred() Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Iker Pedrosa <[email protected]>
Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Iker Pedrosa <[email protected]>
Contributor
sssd-bot
force-pushed
the
getsockopt-freebsd-fix
branch
from
February 27, 2026 08:11
e29efaa to
8a0fade
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.