tests: Fix test_sudo__case_sensitive_false: use /bin/ls and /bin/cat instead of less/more#8449
Merged
Merged
Conversation
madhuriupadhye
marked this pull request as draft
February 13, 2026 12:18
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
madhuriupadhye
force-pushed
the
trust_fix
branch
from
February 13, 2026 12:25
e7b4bd3 to
d6fed7d
Compare
madhuriupadhye
force-pushed
the
trust_fix
branch
from
February 23, 2026 13:41
d6fed7d to
d87b96f
Compare
madhuriupadhye
changed the title
madhuriupadhye
force-pushed
the
trust_fix
branch
2 times, most recently
from
February 24, 2026 06:59
2765742 to
c5d9b9e
Compare
madhuriupadhye
marked this pull request as ready for review
February 24, 2026 07:58
madhuriupadhye
force-pushed
the
trust_fix
branch
from
February 24, 2026 09:41
c5d9b9e to
dfdeb08
Compare
Member
|
/gemini review |
There was a problem hiding this comment.
Code Review
The pull request effectively addresses the issue of less and more commands failing in a non-TTY environment by replacing them with ls and cat. The changes are consistent across the test setup, steps, expected results, and the actual test logic. This improves the reliability of the test_sudo__case_sensitive_false test case.
alexey-tikhonov
approved these changes
Feb 24, 2026
Member
|
Thanks, ACK. @madhuriupadhye, please identify and set proper 'backport-to-*' labels. |
… of less/more test_sudo__case_sensitive_false runs sudo via su -c (no TTY). less and more exit non-zero without a terminal, so the test failed. Switched to /bin/ls and /bin/cat so the run is non-interactive; the test still checks case-insensitive sudo rule merging for user-1 and USER-1. Assisted-by: Cursor (Composer-1.5) Signed-off-by: Madhuri Upadhye <[email protected]> Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Shridhar Gadekar <[email protected]>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_sudo__case_sensitive_false runs sudo via su -c (no TTY). less and more exit
non-zero without a terminal, so the test failed. Switched to /bin/ls and /bin/cat
so the run is non-interactive; the test still checks case-insensitive sudo rule
merging for user-1 and USER-1.
Assisted-by: Cursor (Composer-1.5)