sdap: do not require GID for non-POSIX group#8442
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where sdap_save_group() incorrectly required a GID for non-POSIX groups. The change wraps the GID retrieval logic within a check for posix_group, ensuring that the GID is only required for POSIX groups. This aligns with the intended behavior of allowing non-POSIX groups without GIDs. A new test case has been added to test_identity.py which effectively validates this fix by checking indirect group membership through a nested non-POSIX group. The changes are correct and the test coverage is good.
justin-stephenson
approved these changes
Feb 10, 2026
justin-stephenson
left a comment
justin-stephenson
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the quick fix!
sumit-bose
force-pushed
the
nested_group_members_fix
branch
from
February 16, 2026 08:27
a02692d to
1cb28c9
Compare
alexey-tikhonov
approved these changes
Feb 16, 2026
Member
|
Note: Covscan is green. |
In 85b632d the attribute for the GID was removed from non-POSIX groups. Currently sdap_save_group() still requires the attribute and this patch removes this. sdap_save_group() is currently only used in the code path handling nested groups. To verify the change a test was added were indirect group-members are coming from a nested non-POSIX group. Resolves: SSSD#8441 Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Justin Stephenson <[email protected]>
Contributor
sssd-bot
force-pushed
the
nested_group_members_fix
branch
from
February 17, 2026 08:45
1cb28c9 to
13eec36
Compare
This was referenced Feb 17, 2026
abbra
pushed a commit
to freeipa/freeipa
that referenced
this pull request
Apr 29, 2026
The regression was introduced in 2.12.0, we can't xfail older versions. For more details see: SSSD/sssd#8442 Fixes: https://pagure.io/freeipa/issue/9981 Signed-off-by: David Hanina <[email protected]> Reviewed-By: Florence Blanc-Renaud <[email protected]>
abbra
pushed a commit
to freeipa/freeipa
that referenced
this pull request
May 4, 2026
The regression was introduced in 2.12.0, we can't xfail older versions. For more details see: SSSD/sssd#8442 Fixes: https://pagure.io/freeipa/issue/9981 Signed-off-by: David Hanina <[email protected]> Reviewed-By: Florence Blanc-Renaud <[email protected]>
abbra
pushed a commit
to freeipa/freeipa
that referenced
this pull request
May 4, 2026
The regression was introduced in 2.12.0, we can't xfail older versions. For more details see: SSSD/sssd#8442 Fixes: https://pagure.io/freeipa/issue/9981 Signed-off-by: David Hanina <[email protected]> Reviewed-By: Florence Blanc-Renaud <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 85b632d the attribute for the GID was removed from non-POSIX groups. Currently sdap_save_group() still requires the attribute and this patch removes this.
sdap_save_group() is currently only used in the code path handling nested groups. To verify the change a test was added were indirect group-members are coming from a nested non-POSIX group.
Resolves: #8441