CHILD HELPERS: use less severe debug level#8416
Merged
Merged
Conversation
alexey-tikhonov
added
Trivial
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses an issue where a non-error condition was being logged as a critical failure. As explained in the description, when multiple child process handlers are registered, a SIGCHLD signal triggers all of them, but only one will find its specific child has changed state. The other handlers' calls to waitpid returning 0 is expected behavior. The change appropriately lowers the debug level from SSSDBG_CRIT_FAILURE to SSSDBG_TRACE_LIBS and improves the log message to be more informative. The change is correct and improves the signal-to-noise ratio in the logs.
sumit-bose
approved these changes
Feb 6, 2026
sumit-bose
left a comment
sumit-bose
left a comment
Contributor
There was a problem hiding this comment.
Hi,
thank you for the fix, ACK.
bye,
Sumit
if `child_sig_handler()` is called for unknown pid. If there are N handlers registered and 1 child process exists, all N handlers will be invoked, and N-1 of them will get `waitpid() == 0`. It would be possible to have a single handler registed that would manage a list (or hash table) of `sss_child_ctx`, but it still would have to perform N `waitpid()` calls (`waitpid(-1)` can't be used to avoid handling "foreign" process) so complexity overhead doesn't worth it. Reviewed-by: Sumit Bose <[email protected]>
Contributor
sssd-bot
force-pushed
the
concurrent-handlers
branch
from
February 6, 2026 08:20
d5b8329 to
00ebcec
Compare
This was referenced Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if
child_sig_handler()is called for unknown pid.If there are N handlers registered and 1 child process exists, all N handlers will be invoked, and N-1 of them will get
waitpid() == 0.It would be possible to have a single handler registed that would manage a list (or hash table) of
sss_child_ctx, but it still would have to perform Nwaitpid()calls (waitpid(-1)can't be used to avoid handling "foreign" process) so complexity overhead doesn't worth it.