Fix libini_config related includes.#8409
Merged
Merged
Conversation
alexey-tikhonov
added
no-backport
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves the include directives for libini_config and other related headers. The changes are correct and improve code hygiene by removing an unused include in sssctl_config.c, adjusting include paths for a system library in sss_ini.c, and adding a necessary header to make sss_ini.h self-contained. Overall, these are good cleanups that improve maintainability.
Member
Author
|
Note: Covscan is green. |
Reviewed-by: Tomáš Halman <[email protected]>
Reviewed-by: Tomáš Halman <[email protected]>
This also allows to avoid inclusion of 'ini_config.h' Reviewed-by: Tomáš Halman <[email protected]>
Contributor
sssd-bot
force-pushed
the
dinglibs-includes
branch
from
February 3, 2026 11:50
bbc4943 to
6ffc9c6
Compare
This was referenced Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.