[autobackport: sssd-2-9] Config rules: allow 'ldap_subuid_*' attrs#8404
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly adds several new ldap_subuid_* configuration options to sssdoptions.py and cfg_rules.ini. However, there are a couple of areas for improvement. The new options in cfg_rules.ini are not alphabetically sorted, which is inconsistent with the rest of the file. More importantly, these new options are not documented in the sssd-ldap.5.xml man page, which will make it difficult for users to understand and use them. Adding documentation for these new options is highly recommended.
sumit-bose
left a comment
sumit-bose
left a comment
There was a problem hiding this comment.
Hi,
backport matches the original version, ACK.
bye,
Sumit
Reviewed-by: Sumit Bose <[email protected]> (cherry picked from commit f95f64f)
|
The pull request was accepted by @sumit-bose with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
e184b4d to
7cce8d7
Compare
3 participants
This is an automatic backport of PR#8403 Config rules: allow 'ldap_subuid_*' attrs to branch sssd-2-9, created by @alexey-tikhonov.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
f95f64f - CONFIG: allow 'ldap_subuid_*' attrs
Backported commits
Original Pull Request Body