Skip to content

Config rules: allow 'ldap_subuid_*' attrs#8403

Merged
alexey-tikhonov merged 1 commit into
SSSD:masterfrom
alexey-tikhonov:subid-attrs-cfgrules
Jan 27, 2026
Merged

Config rules: allow 'ldap_subuid_*' attrs#8403
alexey-tikhonov merged 1 commit into
SSSD:masterfrom
alexey-tikhonov:subid-attrs-cfgrules

Conversation

@alexey-tikhonov

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces new ldap_subuid_* and ldap_subgid_* configuration options in src/config/cfg_rules.ini. However, these new options do not appear to have corresponding definitions in src/config/SSSDConfig/sssdoptions.py. This omission can lead to issues with configuration parsing, documentation, and overall system understanding of these new parameters.

Comment thread src/config/cfg_rules.ini

@sumit-bose sumit-bose left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thank you for the fix, the list is the same as in the source code and man page, ACK.

bye,
Sumit

@sssd-bot

Copy link
Copy Markdown
Contributor

The pull request was accepted by @sumit-bose with the following PR CI status:


🟢 CodeQL (success)
🟢 osh-diff-scan:fedora-rawhide-x86_64:upstream (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 Analyze (target) / cppcheck (success)
🟢 Build / freebsd (success)
🟢 Build / make-distcheck (success)
🟢 ci / intgcheck (centos-10) (success)
🟢 ci / intgcheck (fedora-42) (success)
🟢 ci / intgcheck (fedora-43) (success)
🟢 ci / intgcheck (fedora-44) (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-10) (success)
🟢 ci / system (fedora-42) (success)
🟢 ci / system (fedora-43) (success)
🔴 ci / system (fedora-44) (failure)
➖ Coverity scan / coverity (skipped)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot
sssd-bot force-pushed the subid-attrs-cfgrules branch from 680ca14 to 9ef3a9e Compare January 27, 2026 15:28
@alexey-tikhonov
alexey-tikhonov merged commit f95f64f into SSSD:master Jan 27, 2026
16 checks passed
madhuriupadhye added a commit to madhuriupadhye/sssd that referenced this pull request Jul 15, 2026
The subid LDAP configuration validator fix (PR SSSD#8403) is not yet in
RHEL-10.2 builds, causing sssctl config-check to reject the subid LDAP
options as unknown.

Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye added a commit to madhuriupadhye/sssd that referenced this pull request Jul 15, 2026
The subid LDAP configuration validator fix (PR SSSD#8403) is not yet in
RHEL-10.2 builds, causing sssctl config-check to reject the subid LDAP
options as unknown.

Signed-off-by: Madhuri Upadhye <[email protected]>
madhuriupadhye added a commit to madhuriupadhye/sssd that referenced this pull request Jul 17, 2026
The subid LDAP configuration validator fix (PR SSSD#8403) is not yet in
RHEL-10.2 builds, causing sssctl config-check to reject the subid LDAP
options as unknown.

Signed-off-by: Madhuri Upadhye <[email protected]>
sssd-bot pushed a commit to madhuriupadhye/sssd that referenced this pull request Jul 23, 2026
The subid LDAP configuration validator fix (PR SSSD#8403) is not yet in
RHEL-10.2 builds, causing sssctl config-check to reject the subid LDAP
options as unknown.

Signed-off-by: Madhuri Upadhye <[email protected]>
Reviewed-by: Dan Lavu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted backport-to-sssd-2-9 backport-to-sssd-2-12 Trivial A single reviewer is sufficient to review the Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants