Skip to content

updating subid test case to test provider_ldap config#8400

Merged
alexey-tikhonov merged 1 commit into
SSSD:masterfrom
danlavu:tests-subids-ldap-config
Feb 6, 2026
Merged

updating subid test case to test provider_ldap config#8400
alexey-tikhonov merged 1 commit into
SSSD:masterfrom
danlavu:tests-subids-ldap-config

Conversation

@danlavu

@danlavu danlavu commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

No description provided.

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jan 23, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the sssd-test-framework dependency to a specific branch and enhances an existing IPA subid test case. The test case test_ipa__subids_configured is now parameterized to cover both provider=ipa and provider=ldap configurations, ensuring that SSSD can correctly read subid ranges in both scenarios. This improves the test coverage for subid functionality.

@danlavu

danlavu commented Jan 23, 2026

Copy link
Copy Markdown
Contributor Author

Depends on SSSD/sssd-test-framework@0b97f84

@danlavu
danlavu force-pushed the tests-subids-ldap-config branch 4 times, most recently from 9e1a303 to 58cbc0c Compare January 27, 2026 03:29
@alexey-tikhonov

alexey-tikhonov commented Jan 27, 2026

Copy link
Copy Markdown
Member

ldap-provider doesn't support subid ranges in sssd-2-11.
Also added 'blocked' while there is tmp commit.

@alexey-tikhonov

alexey-tikhonov commented Jan 27, 2026

Copy link
Copy Markdown
Member 
ImportError while loading conftest '/home/runner/work/sssd/sssd/sssd/src/tests/system/conftest.py'.
conftest.py:6: in <module>
    from sssd_test_framework.config import SSSDMultihostConfig
.venv/lib/python3.14/site-packages/sssd_test_framework/config.py:7: in <module>
    from .topology import SSSDTopologyMark
.venv/lib/python3.14/site-packages/sssd_test_framework/topology.py:125: in <module>
    class KnownTopology(KnownTopologyBase):
.venv/lib/python3.14/site-packages/sssd_test_framework/topology.py:139: in KnownTopology
    Client = SSSDTopologyMark(
.venv/lib/python3.14/site-packages/sssd_test_framework/topology.py:61: in __init__
    super().__init__(name, topology, fixtures)
E   TypeError: TopologyMark.__init__() takes 3 positional arguments but 4 were given
Error: Process completed with exit code 4.

alexey-tikhonov
alexey-tikhonov reviewed Jan 27, 2026
View reviewed changes
Comment thread src/tests/system/tests/test_ipa.py Outdated
@danlavu
danlavu force-pushed the tests-subids-ldap-config branch 2 times, most recently from 788d58b to 5acf783 Compare January 27, 2026 23:09
@alexey-tikhonov

alexey-tikhonov commented Jan 28, 2026

Copy link
Copy Markdown
Member

ACK, but needs framework PR in.

@alexey-tikhonov alexey-tikhonov self-assigned this Jan 28, 2026
jakub-vavra-cz
jakub-vavra-cz approved these changes Feb 5, 2026
View reviewed changes

@jakub-vavra-cz jakub-vavra-cz left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for green ci.

@alexey-tikhonov

alexey-tikhonov commented Feb 6, 2026

Copy link
Copy Markdown
Member

mypy is red. Could you please check it, @danlavu?

@danlavu

danlavu commented Feb 6, 2026

Copy link
Copy Markdown
Contributor Author

mypy is red. Could you please check it, @danlavu?

tests/test_ipa.py:1096: error: "SSSDCommonConfiguration" has no attribute "ldap_provider" [attr-defined]

Re ran it, green now.

Dan Lavu @sssd-bot
updating subid test case to test provider_ldap config
a9d468f 
Reviewed-by: Alexey Tikhonov <[email protected]>
Reviewed-by: Jakub Vávra <[email protected]>
@sssd-bot

sssd-bot commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

The pull request was accepted by @alexey-tikhonov with the following PR CI status:

🟢 CodeQL (success)
🟢 osh-diff-scan:fedora-rawhide-x86_64:upstream (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 Analyze (target) / cppcheck (success)
🟢 ci / intgcheck (centos-10) (success)
🟢 ci / intgcheck (fedora-42) (success)
🟢 ci / intgcheck (fedora-43) (success)
🟢 ci / intgcheck (fedora-44) (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-10) (success)
🟢 ci / system (fedora-42) (success)
🟢 ci / system (fedora-43) (success)
🟢 ci / system (fedora-44) (success)
➖ Coverity scan / coverity (skipped)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)

There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot
sssd-bot force-pushed the tests-subids-ldap-config branch from 5acf783 to a9d468f Compare February 6, 2026 14:18
@alexey-tikhonov
alexey-tikhonov merged commit 0458e65 into SSSD:master Feb 6, 2026
8 checks passed
@sssd-bot sssd-bot mentioned this pull request Feb 6, 2026
Merged
@danlavu
danlavu deleted the tests-subids-ldap-config branch July 1, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-tikhonov alexey-tikhonov alexey-tikhonov approved these changes
@jakub-vavra-cz jakub-vavra-cz jakub-vavra-cz approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@alexey-tikhonov alexey-tikhonov

@jakub-vavra-cz jakub-vavra-cz

Labels

Accepted backport-to-sssd-2-12 Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danlavu @alexey-tikhonov @sssd-bot @jakub-vavra-cz