FreeBSD CI: Switch to 15.0-RELEASE and enable testing#8306
Merged
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
| echo "::group::Testing" | ||
| # Tests don't work yet | ||
| #gmake check | ||
| gmake -j $(sysctl -n hw.ncpu) check |
Member
There was a problem hiding this comment.
Not sure if '-j' will be "stable" but let's see...
Contributor
Author
There was a problem hiding this comment.
Linux jobs seem to run tests with -j
sssd/.github/workflows/build.yml
Line 41 in 2b43681
Member
There was a problem hiding this comment.
And I wonder if it was the reason of randomly failing
https://github.com/SSSD/sssd/actions/runs/19703082331/job/56443862911
Contributor
Author
|
Why doesn't FreeBSD CI run automatically? |
Member
Some CI jobs require manual approval by a maintainer with write access. |
Contributor
Author
|
Can the FreeBSD build be restarted, please? It failed due to a temporary fluke on the FreeBSD pkg repository side. |
arrowd
marked this pull request as draft
December 17, 2025 17:28
Contributor
Author
|
Thanks. I'll work on the last test failure, although I can't reproduce it locally. |
arrowd
marked this pull request as ready for review
December 26, 2025 14:45
Contributor
Author
|
I finally managed to get |
Member
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the FreeBSD CI to use 15.0-RELEASE and enables testing. The changes include updating shebangs in shell scripts for better portability, adjusting a test assertion to be compatible with FreeBSD, and temporarily disabling a few tests that are failing on the FreeBSD CI environment.
My main feedback is regarding a misleading comment for one of the disabled tests. It's important to have accurate comments, especially when disabling tests, to help future developers understand the context. It would also be beneficial to add comments to the other disabled tests for the same reason.
Overall, the changes look good and are aligned with the goal of improving FreeBSD CI support.
Member
|
Logs of failing (disabled) pam-srv tests:
|
Member
|
Member
|
Member
Common point of failure: @sumit-bose, would you have an idea how to debug this further? |
Contributor
|
Hi, I think is unexpected by the test. Is there a process runnig with UID 123 on the system where the test is running? Does it help if you give bye, |
Member
Thank you. @arrowd, could you please try this instead of disabling tests? |
Contributor
Author
What a sharp eye you have! UID 123 on FreeBSD is the |
Member
Looks fine now. @arrowd, could you please remove |
sumit-bose
reviewed
Jan 19, 2026
sumit-bose
reviewed
Jan 19, 2026
sumit-bose
reviewed
Jan 20, 2026
sumit-bose
approved these changes
Jan 20, 2026
sumit-bose
left a comment
sumit-bose
left a comment
Contributor
There was a problem hiding this comment.
Hi,
I have no further comments, ACK.
bye,
Sumit
alexey-tikhonov
approved these changes
Jan 20, 2026
Member
|
Btw, 'sssd-2.12.0' is out, so maybe https://www.freshports.org/security/sssd2 could be updated to use it :) |
Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Sumit Bose <[email protected]>
Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Sumit Bose <[email protected]>
Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Sumit Bose <[email protected]>
Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Sumit Bose <[email protected]>
Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Sumit Bose <[email protected]>
…r port does Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Sumit Bose <[email protected]>
Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Sumit Bose <[email protected]>
On FreeBSD the UID 123 corresponds to the built-in ntpd user and the machine that runs this test may be running the ntpd daemon. Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Sumit Bose <[email protected]>
Contributor
Contributor
Author
Oh, that's a shame, I wanted this PR to get in before the release. Anyways, this PR concludes my upstreaming efforts. Please get me on the hook whenever FreeBSD CI start to fail. And thanks for merging all our patches too! |
Member
Well, at least this PR didn't touch "product" code, only a couple of tests... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.