KCM: root can't access arbitrary KCM cache#8301
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the special handling for the root user in the KCM ccache access checks. The change is implemented by removing the code that granted root access to any credential cache in kcm_cc_access. The man page documentation is also updated to reflect this change. This is a good security enhancement. My review points out that some comments in the header file kcmsrv_ccache.h are now outdated and should be updated to match the new logic.
alexey-tikhonov
force-pushed
the
kcm-clarify-root
branch
from
December 15, 2025 11:19
ba6991d to
c14a047
Compare
alexey-tikhonov
marked this pull request as ready for review
December 15, 2025 14:41
Member
Author
|
Note: Covscan is green. |
alexey-tikhonov
added
Waiting for review
and removed
coverity
justin-stephenson
self-requested a review
December 17, 2025 16:59
justin-stephenson
approved these changes
Dec 17, 2025
so remove confusing traces suggesting otherwise See: SSSD#7274 (comment) Resolves: SSSD#7274 Reviewed-by: Iker Pedrosa <[email protected]> Reviewed-by: Justin Stephenson <[email protected]>
Contributor
sssd-bot
force-pushed
the
kcm-clarify-root
branch
from
December 19, 2025 08:37
c14a047 to
4afeac1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so remove confusing traces suggesting otherwise
See: #7274 (comment)
Resolves: #7274