cherry pick: 8120 to 2.10 - Migrate missing tests to new framework#8291
Conversation
danlavu
changed the title
danlavu
added
Waiting for review
Trivial
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates several tests from the old integration test framework to the new system test framework, which is a good improvement. I've found a couple of critical issues related to missing imports in test_authentication.py that will cause the tests to fail at runtime. I've also found a minor bug in an assertion message in the new test_nss.py file. Please address these issues.
danlavu
changed the title
4b3812b to
91dcad1
Compare
This PR implements tests from integ/test_ldap.py to new system tests Reviewed-by: Dan Lavu <[email protected]> Reviewed-by: Jakub Vávra <[email protected]> Reviewed-by: Tomáš Halman <[email protected]>
|
The pull request was accepted by @thalman with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
91dcad1 to
3bd5025
Compare
4 participants
This PR implements tests from integ/test_ldap.py to new system tests
Reviewed-by: Dan Lavu [email protected]
Reviewed-by: Jakub Vávra [email protected]