[autobackport: sssd-2-9] intg: remove ent_test.py#8286
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a backport that removes the ent_test.py file. According to the description, this file contains flaky tests for tooling that is being deprecated. The changes correctly remove the test file and its corresponding entry in src/tests/intg/Makefile.am. This is a sensible cleanup to improve CI stability. The changes are correct and I have no concerns.
These tests randomly fails, making CI red. They do not test SSSD, just internal intg tests tooling and since the intg tests are going away, it does not make sense to spend time on it or even mark it as flaky. Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Iker Pedrosa <[email protected]> (cherry picked from commit 97fa9e7)
|
The pull request was accepted by @alexey-tikhonov with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
24ade55 to
2070a5e
Compare
4 participants
This is an automatic backport of PR#8283 intg: remove ent_test.py to branch sssd-2-9, created by @pbrezina.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
97fa9e7 - intg: remove ent_test.py
Backported commits
Original Pull Request Body
These tests randomly fails, making CI red. They do not test SSSD, just
internal intg tests tooling and since the intg tests are going away,
it does not make sense to spend time on it or even mark it as flaky.