tests: Add netgroup offline and nested hierarchy#8272
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces three valuable system tests for SSSD netgroup functionality, covering offline caching, hierarchical removal, and nested modifications. The tests are well-designed and target important use-cases. My feedback focuses on improving the test suite's reporting accuracy. I've identified an instance where pytest.skip should be used instead of raising a ValueError to correctly handle tests on unsupported provider configurations, ensuring they are reported as skipped rather than as errors.
madhuriupadhye
marked this pull request as draft
December 4, 2025 17:02
madhuriupadhye
force-pushed
the
netgroup2
branch
3 times, most recently
from
December 10, 2025 12:51
bfd3ad1 to
450478e
Compare
madhuriupadhye
marked this pull request as ready for review
December 10, 2025 13:00
thalman
approved these changes
Dec 15, 2025
Add new system tests for netgroup functionality: - test_netgroup__offline: Verify netgroups remain accessible from cache when backend goes offline - test_netgroups__step_by_step_removal: Test removing netgroups from hierarchy and deleting them with proper cache invalidation - test_netgroups__nested_modification: Test that adding/removing members in nested netgroups (3-level deep) propagates correctly through the hierarchy Related: https://fedorahosted.org/sssd/ticket/2841 Signed-off-by: Madhuri Upadhye <[email protected]> Reviewed-by: Jakub Vávra <[email protected]> Reviewed-by: Tomáš Halman <[email protected]>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add netgroup tests for offline mode, hierarchy removal, and nested modifications
Add new system tests for netgroup functionality:
Related: https://fedorahosted.org/sssd/ticket/2841