IPA: remove 'ipa_enable_dns_sites' option#8264
Merged
Merged
Conversation
alexey-tikhonov
force-pushed
the
dns-sites-opt
branch
from
December 3, 2025 18:17
60c3794 to
d86e520
Compare
alexey-tikhonov
marked this pull request as ready for review
December 4, 2025 10:22
Member
Author
|
Note: Covscan is green. |
alexey-tikhonov
added
Waiting for review
and removed
coverity
It never worked as intended due to missing server side implementation. :config: An option `ipa_enable_dns_sites`, that never worked due to missing server side implementation, was removed. Reviewed-by: Justin Stephenson <[email protected]> Reviewed-by: Tomáš Halman <[email protected]>
Contributor
sssd-bot
force-pushed
the
dns-sites-opt
branch
from
December 5, 2025 14:30
d86e520 to
af3ec98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It never worked as intended due to missing server side implementation.
:config: An option
ipa_enable_dns_sites, that never worked due to missing server side implementation, was removed.Note that this PR doesn't remove 'ipa_srv.c' code since it is still used by 'ipa_subdomains_server.c :: IPA-IPA trust case'. This is likely unneeded - ipa-subdomain code should be changed to not use 'ipa_srv.c' and plugin can be removed - but this is out of scope of this PR.