Skip to content

[autobackport: sssd-2-9] Test migration sssctl#8234

Merged
alexey-tikhonov merged 2 commits into
SSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8114-to-sssd-2-9
Nov 28, 2025
Merged

[autobackport: sssd-2-9] Test migration sssctl#8234
alexey-tikhonov merged 2 commits into
SSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8114-to-sssd-2-9

Conversation

@sssd-bot

Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#8114 Test migration sssctl to branch sssd-2-9, created by @thalman.

Caution

@thalman The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with CONFLICT!.

You can push changes to this pull request

git remote add sssd-bot [email protected]:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8114-to-sssd-2-9
git checkout SSSD-sssd-backport-pr8114-to-sssd-2-9
git push sssd-bot SSSD-sssd-backport-pr8114-to-sssd-2-9 --force

Original commits
b01df9a - tests: Remove obsolete sssctl tests
cf974c6 - tests: migrate sssctl tests to new framework

Backported commits

  • dc043b0 - CONFLICT! tests: Remove obsolete sssctl tests
  • 5b5fff5 - CONFLICT! tests: migrate sssctl tests to new framework

Original Pull Request Body

This is a bunch of sssctl tests migrated using AI.

The commits are not rebased to show what hel AI provided.

Comment thread src/tests/system/tests/test_sssctl.py Fixed
@thalman
thalman force-pushed the SSSD-sssd-backport-pr8114-to-sssd-2-9 branch 2 times, most recently from 11394ce to ce9e277 Compare November 27, 2025 10:15
@thalman
thalman marked this pull request as ready for review November 28, 2025 09:52
@thalman

thalman commented Nov 28, 2025

Copy link
Copy Markdown
Contributor

the test test_access_control_simple__permits_user_login_based_on_group fails systematically against samba but that is not part of this change

@alexey-tikhonov
alexey-tikhonov removed the request for review from danlavu November 28, 2025 09:54
@alexey-tikhonov alexey-tikhonov added the no-backport This should go to target branch only. label Nov 28, 2025
Those tests are now covered in new testing framework.

Reviewed-by: Alexey Tikhonov <[email protected]>
Reviewed-by: Dan Lavu <[email protected]>
(cherry picked from commit b01df9a)
Reviewed-by: Alexey Tikhonov <[email protected]>
Reviewed-by: Dan Lavu <[email protected]>
(cherry picked from commit cf974c6)
@sssd-bot

Copy link
Copy Markdown
Contributor Author

The pull request was accepted by @alexey-tikhonov with the following PR CI status:


🟢 CodeQL (success)
🟢 rpm-build:centos-stream-9-x86_64:upstream (success)
🟢 Analyze (target) / cppcheck (success)
🟢 Build / make-distcheck (success)
🟢 ci / prepare (success)
🔴 ci / system (centos-9) (failure)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot
sssd-bot force-pushed the SSSD-sssd-backport-pr8114-to-sssd-2-9 branch from ce9e277 to e3a20b9 Compare November 28, 2025 10:03
@alexey-tikhonov
alexey-tikhonov merged commit 7adbc1f into SSSD:sssd-2-9 Nov 28, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted no-backport This should go to target branch only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants