file_watch.c: Do not pass IN_IGNORED to inotify_add_watch#8228
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request addresses an issue where IN_IGNORED was incorrectly passed as an input flag to inotify_add_watch. As correctly identified in the pull request description, IN_IGNORED is an output-only event flag in the inotify API, used to signal that a watch has been removed. Passing it as an input flag is incorrect and, as noted, causes failures on systems like FreeBSD. The change to remove this flag is correct and improves the portability and correctness of the file watching mechanism. The fix is well-targeted and I see no further issues.
|
Hmm, maybe we should add Line 213 in a9f9c5c |
I agree. This would be the only missing detail. |
9ed2962 to
dca1d3a
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request correctly addresses an issue where IN_IGNORED was incorrectly passed as an input flag to inotify_add_watch, which caused failures on FreeBSD. The change in src/util/file_watch.c removes this flag from the input mask, aligning with its nature as an output flag. Complementary to this, the modification in src/util/inotify.c ensures that IN_IGNORED events are properly dispatched, even if not explicitly requested in the watch mask, by including it in the event filtering logic. Both changes are crucial for the correctness and robustness of the inotify-based file watching mechanism, especially on platforms like FreeBSD.
|
Note: Covscan is green. |
This is an output flag and it doesn't make sense to pass it as input. FreeBSD implementation is more finicky, so passing this flag makes the call fail. Fixes the file-watch-tests test on FreeBSD. Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Alejandro López <[email protected]>
dca1d3a to
d753c14
Compare
4 participants
This is an output flag and it doesn't make sense to pass it as input. FreeBSD implementation is more finicky, so passing this flag makes the call fail.
Fixes the file-watch-tests test on FreeBSD.