fixing and making automatic kcm renewal test more forgiving#8183
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to fix a flaky test for KCM ticket renewal. While increasing the sleep time is a good step towards making the test more robust, changing the ticket lifetime from 2s to 1s actually makes the test more prone to race conditions and thus more flaky. I've provided a suggestion to make the test more reliable.
danlavu
force-pushed
the
tests-kcm-renewal
branch
from
November 18, 2025 17:55
619a03f to
8b66cfc
Compare
ikerexxe
added
the
Trivial
danlavu
changed the title
spoore1
approved these changes
Nov 24, 2025
spoore1
left a comment
spoore1
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I ran some tests and it's passing for all of what I've run so far.
alexey-tikhonov
approved these changes
Nov 24, 2025
alexey-tikhonov
added
backport-to-sssd-2-9
backport-to-sssd-2-9-4
Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Scott Poore <[email protected]>
Contributor
sssd-bot
force-pushed
the
tests-kcm-renewal
branch
from
November 24, 2025 19:57
8b66cfc to
53d9f1a
Compare
This was referenced Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.