tests: add test_pac_responder.py#8151
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces an old integration test for the PAC responder with a new system test. The changes involve removing the old C test client and its Python test wrapper, and adding a new system test that uses a pre-built test client. The changes are clean and correctly implement the goal of refactoring the test. I have reviewed the changes and I have no high or critical severity concerns.
sumit-bose
force-pushed
the
test_pac_responder
branch
from
October 20, 2025 19:32
21a76f2 to
f0e9935
Compare
alexey-tikhonov
self-requested a review
October 23, 2025 12:51
pbrezina
force-pushed
the
master
branch
2 times, most recently
from
November 4, 2025 14:27
f5d64b3 to
b854636
Compare
alexey-tikhonov
approved these changes
Nov 15, 2025
Member
|
@sumit-bose, could you please rebase? |
sumit-bose
force-pushed
the
test_pac_responder
branch
from
November 17, 2025 08:10
f0e9935 to
7c54c80
Compare
Contributor
Author
done |
This new system test is a replacment of the integration test with the same name. It depends on a test binary which was added to the SSSD CI containers in SSSD/sssd-ci-containers#150. Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Jakub Vávra <[email protected]>
This test was replaced by a system test with the same name. Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Jakub Vávra <[email protected]>
Contributor
sssd-bot
force-pushed
the
test_pac_responder
branch
from
November 18, 2025 09:37
7c54c80 to
46a8f11
Compare
This was referenced Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new system test is a replacment of the integration test with the
same name. It depends on a test binary which was added to the SSSD CI
containers in SSSD/sssd-ci-containers#150.