Test migration sssctl#8114
Merged
Merged
Conversation
thalman
marked this pull request as ready for review
October 1, 2025 07:54
danlavu
requested changes
Oct 3, 2025
alexey-tikhonov
self-requested a review
October 9, 2025 12:45
alexey-tikhonov
added
Waiting for review
backport-to-sssd-2-9
backport-to-sssd-2-10
backport-to-sssd-2-9-4
danlavu
reviewed
Oct 10, 2025
thalman
force-pushed
the
test_migration_sssctl
branch
from
November 3, 2025 10:38
7e0c405 to
4d9481b
Compare
Contributor
Author
|
Blocked by SSSD/sssd-test-framework#216 |
thalman
force-pushed
the
test_migration_sssctl
branch
6 times, most recently
from
November 3, 2025 15:15
d970a6e to
c86b531
Compare
Contributor
Author
|
Hi guys, I believe that this is ready for second round. We can merge it and I will create followup PR with |
thalman
force-pushed
the
test_migration_sssctl
branch
from
November 3, 2025 19:50
c86b531 to
63688fb
Compare
Contributor
Author
I realized that |
pbrezina
force-pushed
the
master
branch
2 times, most recently
from
November 4, 2025 14:27
f5d64b3 to
b854636
Compare
thalman
force-pushed
the
test_migration_sssctl
branch
from
November 12, 2025 09:35
63688fb to
4215930
Compare
Contributor
Author
|
@alexey-tikhonov, @danlavu, I rebased the PR. It is ready for second review. |
danlavu
approved these changes
Nov 12, 2025
danlavu
left a comment
danlavu
left a comment
Contributor
There was a problem hiding this comment.
Approving, minor nitpick comments.
Member
|
Overall looks good but I have some comments / questions - see inline. |
thalman
force-pushed
the
test_migration_sssctl
branch
from
November 24, 2025 15:38
b07030e to
432fbf5
Compare
alexey-tikhonov
approved these changes
Nov 24, 2025
thalman
force-pushed
the
test_migration_sssctl
branch
from
November 24, 2025 20:35
432fbf5 to
eed4e62
Compare
Contributor
Author
|
I force pushed change fixing last @alexey-tikhonov 's comments about let a comment here if you are fine with that. |
Member
ACK |
Those tests are now covered in new testing framework. Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Dan Lavu <[email protected]>
Reviewed-by: Alexey Tikhonov <[email protected]> Reviewed-by: Dan Lavu <[email protected]>
Contributor
sssd-bot
force-pushed
the
test_migration_sssctl
branch
from
November 25, 2025 09:49
eed4e62 to
76ca67e
Compare
This was referenced Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bunch of sssctl tests migrated using AI.
The commits are not rebased to show what hel AI provided.