Skip to content

Tests:cache_credentials = true not working for 2-9#8032

Merged
sumit-bose merged 1 commit into
SSSD:sssd-2-9from
shridhargadekar:offline_2-9
Dec 2, 2025
Merged

Tests:cache_credentials = true not working for 2-9#8032
sumit-bose merged 1 commit into
SSSD:sssd-2-9from
shridhargadekar:offline_2-9

Conversation

@shridhargadekar

@shridhargadekar shridhargadekar commented Jul 11, 2025

Copy link
Copy Markdown
Contributor

Backporting to sssd-2-9 branch,
Tests for cache_credentials = true not working in sssd, with specified PAM configuration in /etc/pam.d/system-auth and /etc/pam.d/password-auth

verifies #7968

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 11, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The code changes introduce a new test case for cache_credentials = true with a custom PAM stack. The review focuses on improving the robustness of the test setup to prevent potential flakiness.

Comment thread src/tests/system/tests/test_authentication.py Outdated
@shridhargadekar shridhargadekar mentioned this pull request Jul 11, 2025
Closed
@alexey-tikhonov alexey-tikhonov added the no-backport This should go to target branch only. label Jul 14, 2025
@ikerexxe
ikerexxe requested a review from sumit-bose July 15, 2025 12:34
@ikerexxe ikerexxe added the Trivial A single reviewer is sufficient to review the Pull Request label Jul 15, 2025
sumit-bose
sumit-bose reviewed Jul 29, 2025
View reviewed changes
Comment thread src/tests/system/tests/test_authentication.py Outdated
sumit-bose
sumit-bose reviewed Jul 29, 2025
View reviewed changes
Comment thread src/tests/system/tests/test_authentication.py Outdated
@alexey-tikhonov alexey-tikhonov mentioned this pull request Nov 21, 2025
Merged
@shridhargadekar
shridhargadekar force-pushed the offline_2-9 branch 4 times, most recently from e9c7c96 to 5b9ab77 Compare November 21, 2025 13:08
@sumit-bose

sumit-bose commented Nov 28, 2025

Copy link
Copy Markdown
Contributor

Hi,

the current version of this backported test does not include the latest changes to the original one, e.g. usage of authselect. Please update.

bye,
Sumit

@shridhargadekar

shridhargadekar commented Nov 28, 2025

Copy link
Copy Markdown
Contributor Author

Hi Sumit,
I've applied the latest changes from the original #8020 to this. Please check.

madhuriupadhye
madhuriupadhye requested changes Dec 2, 2025
View reviewed changes
Comment thread src/tests/system/tests/test_authentication.py Outdated
Comment thread src/tests/system/tests/test_authentication.py Outdated
Comment thread src/tests/system/tests/test_authentication.py
Comment thread src/tests/system/tests/test_authentication.py Outdated
@shridhargadekar
shridhargadekar force-pushed the offline_2-9 branch 2 times, most recently from 6864078 to 4c612de Compare December 2, 2025 11:18
madhuriupadhye
madhuriupadhye requested changes Dec 2, 2025
View reviewed changes
Comment thread src/tests/system/tests/test_authentication.py Outdated
madhuriupadhye
madhuriupadhye approved these changes Dec 2, 2025
View reviewed changes

@madhuriupadhye madhuriupadhye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@alexey-tikhonov alexey-tikhonov removed the Trivial A single reviewer is sufficient to review the Pull Request label Dec 2, 2025
sumit-bose
sumit-bose approved these changes Dec 2, 2025
View reviewed changes

@sumit-bose sumit-bose left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thank you for the update, besides some formating name naming changes the test code is the same as the one in master, ACK.

bye,
Sumit

@shridhargadekar @sssd-bot
Tests:cache_credentials = true not working for 2-9
67e4aaf 
Backporting to sssd-2-9 branch,
Tests for cache_credentials = true not working in sssd,
with specified PAM configuration in /etc/pam.d/system-auth
and /etc/pam.d/password-auth

verifies SSSD#7968

Reviewed-by: Madhuri Upadhye <[email protected]>
Reviewed-by: Sumit Bose <[email protected]>
@sssd-bot

sssd-bot commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

The pull request was accepted by @sumit-bose with the following PR CI status:

🟢 CodeQL (success)
🟢 Analyze (target) / cppcheck (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-9) (success)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)

There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sumit-bose
sumit-bose merged commit f9c30ef into SSSD:sssd-2-9 Dec 2, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sumit-bose sumit-bose sumit-bose approved these changes
@madhuriupadhye madhuriupadhye madhuriupadhye approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@sumit-bose sumit-bose

@madhuriupadhye madhuriupadhye

Labels

Accepted no-backport This should go to target branch only. Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@shridhargadekar @sumit-bose @sssd-bot @madhuriupadhye @ikerexxe @alexey-tikhonov