SYSDB: Fixing of sudorule without a sudoUser#80
Closed
celestian wants to merge 1 commit into
Closed
Conversation
Contributor
|
This would work, but wouldn't it be better to return a custom error code instead of EINVAL so that we are sure we are not skipping some error from ldb or somewhere else? |
This patch solved a regression caused by the recent patches to lowercase sudoUser -- in case sudoUser is missing completely, we abort the processing of this rule and all others. With this patch, we return ERR_MALFORMED_ENTRY and gracefully skip the malformed rule instead. Resolves: https://fedorahosted.org/sssd/ticket/3241
Contributor
Author
|
New version pushed. |
celestian
changed the title
Contributor
|
ACK, the rule without a sudoUser attribute is properly skipped and the other rules are normally stored. |
Contributor
|
the rawhide failure is not related, it's a know bug in the latest python-urllib release. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch solved a regression caused by the recent patches
to lowercase sudoUser -- in case sudoUser is missing completely,
we abort the processing of this rule and all others.
With this patch, we return EINVAL and gracefully skip
the malgormed rule instead.
Resolves:
https://fedorahosted.org/sssd/ticket/3241