Skip to content

IPA: return ENOENT if ipa_get_config yields nothing#7928

Closed
alexey-tikhonov wants to merge 2 commits into
SSSD:masterfrom
alexey-tikhonov:log-levels
Closed

IPA: return ENOENT if ipa_get_config yields nothing#7928
alexey-tikhonov wants to merge 2 commits into
SSSD:masterfrom
alexey-tikhonov:log-levels

Conversation

@alexey-tikhonov

@alexey-tikhonov alexey-tikhonov commented Apr 14, 2025

Copy link
Copy Markdown
Member

and handle this error code properly.

@alexey-tikhonov
IPA: return ENOENT if ipa_get_config yields nothing
3306aec 
and handle this error code properly.
@alexey-tikhonov alexey-tikhonov mentioned this pull request Apr 14, 2025
Closed
@justin-stephenson justin-stephenson self-assigned this Apr 14, 2025
@justin-stephenson

justin-stephenson commented Apr 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks for the PR, would you also be willing to add justin-stephenson@afd7bfa here? It makes use of ipa_get_config_send more clear.

@alexey-tikhonov

alexey-tikhonov commented Apr 14, 2025

Copy link
Copy Markdown
Member Author

Thanks for the PR, would you also be willing to add justin-stephenson@afd7bfa here? It makes use of ipa_get_config_send more clear.

+++ b/src/providers/ipa/ipa_selinux.c
@@ -1066,13 +1066,15 @@ static void ipa_get_config_step(struct tevent_req *req)
     struct ipa_get_selinux_state *state = tevent_req_data(req,
                                                   struct ipa_get_selinux_state);
     struct ipa_id_ctx *id_ctx = state->selinux_ctx->id_ctx;
+    const char *attrs[] = {IPA_CONFIG_SELINUX_DEFAULT_USER_CTX,
+                           IPA_CONFIG_MIGRATION_ENABLED, NULL};

-- shouldn't it be IPA_CONFIG_SELINUX_MAP_ORDER instead of IPA_CONFIG_MIGRATION_ENABLED?

@justin-stephenson

justin-stephenson commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

Thanks for the PR, would you also be willing to add justin-stephenson@afd7bfa here? It makes use of ipa_get_config_send more clear.

+++ b/src/providers/ipa/ipa_selinux.c
@@ -1066,13 +1066,15 @@ static void ipa_get_config_step(struct tevent_req *req)
     struct ipa_get_selinux_state *state = tevent_req_data(req,
                                                   struct ipa_get_selinux_state);
     struct ipa_id_ctx *id_ctx = state->selinux_ctx->id_ctx;
+    const char *attrs[] = {IPA_CONFIG_SELINUX_DEFAULT_USER_CTX,
+                           IPA_CONFIG_MIGRATION_ENABLED, NULL};

-- shouldn't it be IPA_CONFIG_SELINUX_MAP_ORDER instead of IPA_CONFIG_MIGRATION_ENABLED?

Yes, I just noticed it also and fixed it.

@alexey-tikhonov

alexey-tikhonov commented Apr 15, 2025

Copy link
Copy Markdown
Member Author

Yes, I just noticed it also and fixed it.

Thank you, added.

github-advanced-security[bot]
github-advanced-security AI found potential problems Apr 15, 2025
View reviewed changes
Comment thread src/providers/ipa/ipa_config.c Fixed
@justin-stephenson @alexey-tikhonov
IPA: ipa_get_config_send() was updated
42012a4 
to require list of attrs explicitly.
@alexey-tikhonov alexey-tikhonov added coverity Trigger a coverity scan Waiting for review labels Apr 15, 2025
sumit-bose
sumit-bose approved these changes Apr 15, 2025
View reviewed changes

@sumit-bose sumit-bose left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thank you both for the patches.

Afaik, it can be expected that IPA_CONFIG_MIGRATION_ENABLED is always present, so strictly speaking not finding it would be an error. But given the this flag will be only used in a limited time-frame after a migration, I think it is ok to treat ENOENT not as an error. ACK.

bye,
Sumit

@alexey-tikhonov alexey-tikhonov added Accepted coverity Trigger a coverity scan Ready to push and removed Waiting for review coverity Trigger a coverity scan labels Apr 15, 2025
@alexey-tikhonov

alexey-tikhonov commented Apr 16, 2025

Copy link
Copy Markdown
Member Author

Pushed PR: #7928

  • master
    • ae59f29 - IPA: ipa_get_config_send() was updated
    • fd56267 - IPA: return ENOENT if ipa_get_config yields nothing
  • sssd-2-9
    • bbb7b79 - IPA: ipa_get_config_send() was updated
    • ecaa49c - IPA: return ENOENT if ipa_get_config yields nothing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justin-stephenson justin-stephenson justin-stephenson approved these changes
@sumit-bose sumit-bose sumit-bose approved these changes

Assignees

@justin-stephenson justin-stephenson

@sumit-bose sumit-bose

Labels

backport-to-sssd-2-9 coverity Trigger a coverity scan Pushed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexey-tikhonov @justin-stephenson @sumit-bose @github-advanced-security