Tests: Housekeeping and Clean Sweep of Sevice/Logging suite by jakub-vavra-cz · Pull Request #7891 · SSSD/sssd

jakub-vavra-cz · 2025-03-21T12:33:46Z

No description provided.

jakub-vavra-cz · 2025-03-25T13:37:04Z

I am not sure why the test is failing again. It was running fine when executed locally.

danlavu

Some questions, nitpicks, but it's great, thank you!

alexey-tikhonov · 2025-03-26T17:26:45Z

This uncovers following things that likely need to be fixed in the code:

(1) test_logging__default_settings_does_not_log_user_logins (ipa)

[be[test]] [ipa_subdomains_refresh_passkey_done] (0x3f7c0): [RID#1] Passkey feature is not configured on IPA server
[be[test]] [ipa_domain_resolution_order_done] (0x3f7c0): [RID#1] Failed to get the domains' resolution order configuration from the server [22]: Invalid argument
[be[test]] [ipa_subdomains_handler_done] (0x0020): [RID#1] Unable to refresh subdomains [22]: Invalid argument

(2) test_logging__default_settings_does_not_log_user_logins (ldap)

[ssh] [cache_req_common_process_dp_reply] (0x3f7c0): [CID#1] CR #0: Data Provider Error: 3, 22, Invalid argument

(3) test_logging__default_settings_does_not_log_user_logins (samba) (and the same with 'proxy')

[ssh] [cache_req_common_process_dp_reply] (0x3f7c0): [CID#1] CR #0: Could not get account info [1432158215]: DP target is not configured

Most probably all fixes will be decrease log level, but to be confirmed.

jakub-vavra-cz · 2025-04-03T09:01:32Z

This uncovers following things that likely need to be fixed in the code:

(1) test_logging__default_settings_does_not_log_user_logins (ipa)
    < (2025-03-26 14:43:29): [be[test]] [ipa_subdomains_refresh_passkey_done] (0x3f7c0): [RID#1] Passkey feature is not configured on IPA server
    < (2025-03-26 14:43:29): [be[test]] [ipa_domain_resolution_order_done] (0x3f7c0): [RID#1] Failed to get the domains' resolution order configuration from the server [22]: Invalid argument
    < (2025-03-26 14:43:29): [be[test]] [ipa_subdomains_handler_done] (0x0020): [RID#1] Unable to refresh subdomains [22]: Invalid argument
(2) test_logging__default_settings_does_not_log_user_logins (ldap)
    < (2025-03-26 15:17:43): [ssh] [cache_req_common_process_dp_reply] (0x3f7c0): [CID#1] CR #0: Data Provider Error: 3, 22, Invalid argument
(3) test_logging__default_settings_does_not_log_user_logins (samba) (and the same with 'proxy')
    < (2025-03-26 15:43:21): [ssh] [cache_req_common_process_dp_reply] (0x3f7c0): [CID#1] CR #0: Could not get account info [1432158215]: DP target is not configured
Most probably all fixes will be decrease log level, but to be confirmed.

For ipa this is the config:

[sssd]
services = nss, pam, ssh
domains = test

[domain/test]
ipa_domain = ipa.test
id_provider = ipa
access_provider = ipa
ipa_server = master.ipa.test
dyndns_update = False
fallback_homedir = /home/%%u

jakub-vavra-cz · 2025-04-11T13:16:11Z

@jakub-vavra-cz, could you please rebase?

rebased & pushed @alexey-tikhonov .

alexey-tikhonov · 2025-04-12T10:37:21Z

(1) test_logging__default_settings_does_not_log_user_logins (ipa)

[be[test]] [ipa_subdomains_refresh_passkey_done] (0x3f7c0): [RID#1] Passkey feature is not configured on IPA server
[be[test]] [ipa_domain_resolution_order_done] (0x3f7c0): [RID#1] Failed to get the domains' resolution order configuration from the server [22]: Invalid argument
[be[test]] [ipa_subdomains_handler_done] (0x0020): [RID#1] Unable to refresh subdomains [22]: Invalid argument

@justin-stephenson , do you remember the reason why 2 messages above are logged as SSSDBG_IMPORTANT_INFO? (fa326be)

alexey-tikhonov · 2025-04-12T11:24:29Z

(2) test_logging__default_settings_does_not_log_user_logins (ldap)
[ssh] [cache_req_common_process_dp_reply] (0x3f7c0): [CID#1] CR #0: Data Provider Error: 3, 22, Invalid argument
(3) test_logging__default_settings_does_not_log_user_logins (samba) (and the same with 'proxy')
[ssh] [cache_req_common_process_dp_reply] (0x3f7c0): [CID#1] CR #0: Could not get account info [1432158215]: DP target is not configured

@jakub-vavra-cz, could you please run those 2 tests with 'debug_level = 9' in the '[ssh]' and domain sections of sssd.conf and send me logs?

justin-stephenson · 2025-04-14T12:35:26Z

(1) test_logging__default_settings_does_not_log_user_logins (ipa)
[be[test]] [ipa_subdomains_refresh_passkey_done] (0x3f7c0): [RID#1] Passkey feature is not configured on IPA server
[be[test]] [ipa_domain_resolution_order_done] (0x3f7c0): [RID#1] Failed to get the domains' resolution order configuration from the server [22]: Invalid argument
[be[test]] [ipa_subdomains_handler_done] (0x0020): [RID#1] Unable to refresh subdomains [22]: Invalid argument
@justin-stephenson , do you remember the reason why 2 messages above are logged as SSSDBG_IMPORTANT_INFO? (fa326be)

I'm afraid I don't remember. Would SSSDBG_MINOR_FAILURE be more appropriate? Feel free to adjust as needed.

alexey-tikhonov · 2025-04-14T17:54:33Z

(1) test_logging__default_settings_does_not_log_user_logins (ipa)
[be[test]] [ipa_subdomains_refresh_passkey_done] (0x3f7c0): [RID#1] Passkey feature is not configured on IPA server
[be[test]] [ipa_domain_resolution_order_done] (0x3f7c0): [RID#1] Failed to get the domains' resolution order configuration from the server [22]: Invalid argument
[be[test]] [ipa_subdomains_handler_done] (0x0020): [RID#1] Unable to refresh subdomains [22]: Invalid argument
@justin-stephenson , do you remember the reason why 2 messages above are logged as SSSDBG_IMPORTANT_INFO? (fa326be)
I'm afraid I don't remember. Would SSSDBG_MINOR_FAILURE be more appropriate? Feel free to adjust as needed.

#7928

alexey-tikhonov · 2025-04-16T07:40:15Z

Please rebase on the top of merged #7928

alexey-tikhonov · 2025-04-24T07:52:31Z

@jakub-vavra-cz, ping:

Please rebase on the top of merged #7928

and #7891 (comment)

Merged tests for sssd offline message in logs and syslog. Split backend offline(unreachable) and dns resolution error scenario. Check that user login does not generate logs on default debug level extended to all providers. Added link to debug level documentation. Dropped references to (now-irrelevant) bugzillas in rewritten tests.

jakub-vavra-cz · 2025-04-24T12:56:25Z

@jakub-vavra-cz, ping:

Please rebase on the top of merged #7928

and #7891 (comment)
@alexey-tikhonov rebased onto master

alexey-tikhonov · 2025-05-13T08:24:23Z

Looks like there are 3 issues:

(1) man page doesn't mention that 'ldap' is supported

(2) imo, it's wrong that ldap-provider returns 'Invalid argument' for 'localhost'

(3) wrt 'DP target is not configured' seen with a default debug level - I'm not so sure.
On the one hand, if somebody explicitly configures 'ssh' in 'services' list it's reasonable to expect that configured domain supports this service and to warn if it doesn't.
On the other hand, in theory there maybe multiple domains configured, with only some of them supporting 'hostid' lookups. In this setup it is expected that other domains will fail this lookup and warning isn't needed.

(2) & (3) needs to be fixed before merging this PR to avoid having yet another one always failing test.

shridhargadekar · 2025-05-20T13:59:14Z

LGTM, Apart from above added comments from Alexey.

jakub-vavra-cz added Waiting for review Tests labels Mar 21, 2025

jakub-vavra-cz force-pushed the logging branch from 8ccc5f1 to 01bd23e Compare March 21, 2025 13:02

andreboscatto requested a review from danlavu March 25, 2025 13:34

andreboscatto assigned danlavu Mar 25, 2025

andreboscatto requested a review from shridhargadekar March 25, 2025 13:34

andreboscatto assigned shridhargadekar Mar 25, 2025

andreboscatto requested a review from alexey-tikhonov March 25, 2025 13:35

andreboscatto assigned danlavu, shridhargadekar and alexey-tikhonov and unassigned danlavu and shridhargadekar Mar 25, 2025

jakub-vavra-cz added backport-to-sssd-2-9 backport-to-sssd-2-10 labels Mar 25, 2025

jakub-vavra-cz force-pushed the logging branch 2 times, most recently from d2f45ae to c5779e7 Compare March 26, 2025 13:52

danlavu reviewed Mar 26, 2025

View reviewed changes

Comment thread src/tests/system/tests/test_logging.py Outdated

Comment thread src/tests/system/tests/test_logging.py

Comment thread src/tests/system/tests/test_logging.py

Comment thread src/tests/system/tests/test_logging.py Outdated

Comment thread src/tests/system/tests/test_logging.py Outdated

alexey-tikhonov reviewed Mar 26, 2025

View reviewed changes

Comment thread src/tests/system/tests/test_logging.py

alexey-tikhonov added Changes requested and removed Waiting for review labels Mar 31, 2025

jakub-vavra-cz force-pushed the logging branch 2 times, most recently from d1cd2ea to 9408494 Compare April 3, 2025 08:06

jakub-vavra-cz requested review from alexey-tikhonov and danlavu April 3, 2025 08:46

jakub-vavra-cz added Waiting for review and removed Changes requested labels Apr 3, 2025

shridhargadekar requested changes Apr 11, 2025

View reviewed changes

Comment thread src/tests/system/tests/test_logging.py Outdated

Comment thread src/tests/system/tests/test_logging.py Outdated

Comment thread src/tests/system/tests/test_logging.py

jakub-vavra-cz force-pushed the logging branch from 5fd94ee to 8f443ba Compare April 14, 2025 07:21

alexey-tikhonov added Changes requested and removed Waiting for review labels Apr 24, 2025

jakub-vavra-cz force-pushed the logging branch from 8f443ba to 66e2a3e Compare April 24, 2025 12:55

jakub-vavra-cz added Waiting for review and removed Changes requested labels Apr 24, 2025

jakub-vavra-cz requested a review from shridhargadekar April 24, 2025 12:57

alexey-tikhonov added the Blocked label May 13, 2025

shridhargadekar reviewed May 20, 2025

View reviewed changes

Comment thread src/tests/system/tests/test_logging.py

alexey-tikhonov added the branch: sssd-2-11 label Jun 5, 2025

alexey-tikhonov removed their assignment Jun 5, 2025

jakub-vavra-cz closed this Aug 7, 2025

jakub-vavra-cz deleted the logging branch August 7, 2025 10:28

jakub-vavra-cz mentioned this pull request Mar 11, 2026

Tests: Clean sweep in logging suite #8512

Merged

Uh oh!

Conversation

jakub-vavra-cz commented Mar 21, 2025

Uh oh!

jakub-vavra-cz commented Mar 25, 2025

Uh oh!

danlavu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexey-tikhonov commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakub-vavra-cz commented Apr 3, 2025

Uh oh!

jakub-vavra-cz commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexey-tikhonov commented Apr 12, 2025

Uh oh!

alexey-tikhonov commented Apr 12, 2025

Uh oh!

justin-stephenson commented Apr 14, 2025

Uh oh!

alexey-tikhonov commented Apr 14, 2025

Uh oh!

alexey-tikhonov commented Apr 16, 2025

Uh oh!

alexey-tikhonov commented Apr 24, 2025

Uh oh!

jakub-vavra-cz commented Apr 24, 2025

Uh oh!

alexey-tikhonov commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

shridhargadekar commented May 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alexey-tikhonov commented Mar 26, 2025 •

edited

Loading

jakub-vavra-cz commented Apr 11, 2025 •

edited

Loading

alexey-tikhonov commented May 13, 2025 •

edited

Loading