Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/2165
- Created at 2013-12-01 18:33:06 by hwoarang
- Closed as Fixed
- Assigned to nobody
Hi,
I am the maintainer of the sssd package on Gentoo Linux. Could you please consider apply the following patch to the init script you provide with sssd to make it work properly for Gentoo Linux?
Two changes are needed:
- use xdm if possible to allow login-managers to use sssd for user logins
- Send debug output to file instead of stderr
Patch: http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-auth/sssd/files/sssd-1.9.6-fix-init.patch?view=markup
Tested with 1.9.6. I haven't packaged 1.11.2 yet
Comments
Comment from jhrozek at 2013-12-02 09:29:13
Hi,
I admit I don't know Gentoo packaging at all, but would you mind sending the patch in git format-patch format to sssd-devel list? You don't have to subscribe, I can let your e-mail through.
One question about the patch - is xdm in gentoo any generic display manager? Will that make sssd work also with kdm/gdm/.. ?
Comment from hwoarang at 2013-12-02 09:49:38
Hi,
Yeah I will send a patch to the mailing list. But this
https://fedorahosted.org/sssd/wiki/Contribute
said to open a ticket here :) There are a few other problems with the init script, such as @sbidir@ being expanded to ${exec_prefix} which is not defined anywhere in the init script to the init script expects to find sssd in /sbin instead of /usr/sbin. I will fix both and send a proper patch.
as for the xdm, no, xdm is just a wrapper for any login manager. So you configure xdm to use kdm,gdm,lxdm,etc and then you start the xdm init script and it will bring up the login manager of your choice.
Comment from jhrozek at 2013-12-02 10:43:07
Replying to [comment:2 hwoarang]:
Hi,
Yeah I will send a patch to the mailing list. But this
https://fedorahosted.org/sssd/wiki/Contribute
said to open a ticket here :)
Right, we don't receive many tickets with patches :) and I was also hoping there would be some Gentoo user on the list who might help with testing the patch as I don't have even a Gentoo VM around. But given you're the Gentoo maintainer, I don't have a problem with pushing the patch from you without a second review.
There are a few other problems with the init script, such as @sbidir@ being expanded to ${exec_prefix} which is not defined anywhere in the init script to the init script expects to find sssd in /sbin instead of /usr/sbin. I will fix both and send a proper patch.
OK, thanks a lot!
as for the xdm, no, xdm is just a wrapper for any login manager. So you configure xdm to use kdm,gdm,lxdm,etc and then you start the xdm init script and it will bring up the login manager of your choice.
Thank you for the clarification.
Comment from jhrozek at 2013-12-04 23:12:08
Patches were accepted upstream. Thank you for the contribution!
milestone: NEEDS_TRIAGE => SSSD 1.11.3
resolution: => fixed
status: new => closed
Comment from jhrozek at 2013-12-19 09:45:06
Gentoo bug doesn't need a BZ clone
rhbz: => 0
Comment from jhrozek at 2013-12-19 19:16:26
Fields changed
changelog: => N/A, just a simple fix
Comment from hwoarang at 2017-02-24 14:29:24
Metadata Update from @hwoarang:
- Issue set to the milestone: SSSD 1.11.3
Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/2165
Hi,
I am the maintainer of the sssd package on Gentoo Linux. Could you please consider apply the following patch to the init script you provide with sssd to make it work properly for Gentoo Linux?
Two changes are needed:
Patch: http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-auth/sssd/files/sssd-1.9.6-fix-init.patch?view=markup
Tested with 1.9.6. I haven't packaged 1.11.2 yet
Comments
Comment from jhrozek at 2013-12-02 09:29:13
Hi,
I admit I don't know Gentoo packaging at all, but would you mind sending the patch in
git format-patchformat to sssd-devel list? You don't have to subscribe, I can let your e-mail through.One question about the patch - is
xdmin gentoo any generic display manager? Will that make sssd work also with kdm/gdm/.. ?Comment from hwoarang at 2013-12-02 09:49:38
Hi,
Yeah I will send a patch to the mailing list. But this
https://fedorahosted.org/sssd/wiki/Contribute
said to open a ticket here :) There are a few other problems with the init script, such as @sbidir@ being expanded to ${exec_prefix} which is not defined anywhere in the init script to the init script expects to find sssd in /sbin instead of /usr/sbin. I will fix both and send a proper patch.
as for the xdm, no, xdm is just a wrapper for any login manager. So you configure xdm to use kdm,gdm,lxdm,etc and then you start the xdm init script and it will bring up the login manager of your choice.
Comment from jhrozek at 2013-12-02 10:43:07
Replying to [comment:2 hwoarang]:
Right, we don't receive many tickets with patches :) and I was also hoping there would be some Gentoo user on the list who might help with testing the patch as I don't have even a Gentoo VM around. But given you're the Gentoo maintainer, I don't have a problem with pushing the patch from you without a second review.
OK, thanks a lot!
Thank you for the clarification.
Comment from jhrozek at 2013-12-04 23:12:08
Patches were accepted upstream. Thank you for the contribution!
milestone: NEEDS_TRIAGE => SSSD 1.11.3
resolution: => fixed
status: new => closed
Comment from jhrozek at 2013-12-19 09:45:06
Gentoo bug doesn't need a BZ clone
rhbz: => 0
Comment from jhrozek at 2013-12-19 19:16:26
Fields changed
changelog: => N/A, just a simple fix
Comment from hwoarang at 2017-02-24 14:29:24
Metadata Update from @hwoarang: