Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/1898

• Created at 2013-04-29 14:35:24 by mzidek
• Closed at 2017-08-03 11:14:07 as Fixed
• Assigned to nobody

We have some header files consumed by both server and client code. Header files consumed by the client code should remain minimal and not include anything unnecessary for the client. We have warning at the beginning of these headers to avoid adding functions and macros needed by the server (but not needed by the client):

+/* CAUTION:
+ * This file is also used in sss_client (pam, nss). Therefore it has to be
+ * minimalist and cannot include DEBUG macros or header file util.h.
+ */

The warning message can be easily overseen especially in larger header files. Moving these headers to special folder (something like src/shared) would make it harder to oversee the fact that we work with headers shared with the client. It would be also easier to identify these headers when looking for them in the src tree.

Comments

Comment from dpal at 2013-05-02 15:15:55

Before starting on this ticket ask for details on the sssd-devel list.

keywords: => easyfix
milestone: NEEDS_TRIAGE => SSSD 1.12 beta
rhbz: => 0

Comment from jhrozek at 2016-02-16 14:40:30

We have more urgent tasks on our plate..

changelog: =>
mark: => 0
milestone: SSSD 1.14 beta => SSSD 1.15 beta
sensitive: => 0

Comment from mzidek at 2017-02-24 14:41:45

Metadata Update from @mzidek:

• Issue set to the milestone: SSSD Future releases (no date set yet)

Comment from jhrozek at 2017-07-12 14:07:55

Metadata Update from @jhrozek:

• Custom field design_review reset (from 0)
• Custom field mark reset (from 0)
• Custom field patch reset (from 0)
• Custom field review reset (from 0)
• Custom field sensitive reset (from 0)
• Custom field testsupdated reset (from 0)
• Issue close_status updated to: None
• Issue tagged with: easyfix

Comment from amitkumar25nov at 2017-07-28 12:58:15

PR:#333

Comment from jhrozek at 2017-08-03 11:13:41

• master: 3996e39

Comment from jhrozek at 2017-08-03 11:13:41

Metadata Update from @jhrozek:

• Custom field design_review reset (from false)
• Custom field mark reset (from false)
• Custom field patch reset (from false)
• Custom field review reset (from false)
• Custom field sensitive reset (from false)
• Custom field testsupdated reset (from false)

Comment from jhrozek at 2017-08-03 11:14:07

Metadata Update from @jhrozek:

• Custom field design_review reset (from false)
• Custom field mark reset (from false)
• Custom field patch reset (from false)
• Custom field review reset (from false)
• Custom field sensitive reset (from false)
• Custom field testsupdated reset (from false)
• Issue close_status updated to: Fixed
• Issue set to the milestone: SSSD 1.15.4 (was: SSSD Future releases (no date set yet))
• Issue status updated to: Closed (was: Open)

Comment from jhrozek at 2017-10-19 22:52:13

Metadata Update from @jhrozek:

• Custom field design_review reset (from false)
• Custom field mark reset (from false)
• Custom field patch reset (from false)
• Custom field review reset (from false)
• Custom field sensitive reset (from false)
• Custom field testsupdated reset (from false)
• Issue set to the milestone: SSSD 1.16.0 (was: SSSD 1.15.4)