Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/1074

• Created at 2011-10-28 17:57:06 by sgallagh
• Closed as Fixed
• Assigned to dpal

1564 /* Make sure that there is anything to search */
1565 type &= COL_TYPE_ANY;
At conditional (1): "property_to_find == NULL" taking the true branch.
At conditional (2): "type == 0" taking the false branch.
CID 11087: Dereference after null check (FORWARD_NULL)Comparing "property_to_find" to null implies that "property_to_find" might be null.
Dereferencing null variable "property_to_find".
1566 if (((property_to_find == NULL) && (type == 0)) ||
1567 ((*property_to_find == '\0') && (type == 0))) {
1568 TRACE_ERROR_NUMBER("No item search criteria specified - returning error!", ENOENT);
1569 return ENOENT;
1570 }

Comments

Comment from dpal at 2011-11-03 14:36:21

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.7.0
owner: dpal => sgallagh

Comment from dpal at 2011-11-03 14:36:30

Fields changed

priority: major => minor

Comment from dpal at 2011-11-17 03:01:45

This is really strange issue. I see that it is wrong but I added tests to make it crash and it did not. I have a fix but before I submit it I want to be sure I am testing the right thing.

Comment from sgallagh at 2011-11-18 15:11:19

Fixed by:
- f5dbb4ecb9bdf991625d5e48d039a66a765b292c (master)
- b55824ab7821f53e878908dcbddf7cf8a2a78807 (ding_libs-0-1)

owner: sgallagh => dpal

Comment from sgallagh at 2011-11-18 15:11:24

Fields changed

resolution: => fixed
status: new => closed

Comment from sgallagh at 2012-01-30 22:12:52

Fields changed

rhbz: => 0

Comment from sgallagh at 2017-02-24 14:33:52

Metadata Update from @sgallagh:

• Issue assigned to dpal
• Issue set to the milestone: SSSD 1.7.0