Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: SSSD/sssd
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: jhrozek/sssd
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: review
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 9 files changed
  • 3 contributors

Commits on Jan 17, 2019

  1. MULTIHOST: Do not use the deprecated namespace 

    This issue was causing warnings with the current pytest versions as
installed from pip.

See:
https://docs.pytest.org/en/latest/deprecations.html#pytest-namespace
    @jhrozek
    jhrozek committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    5f82750 View commit details
    Browse the repository at this point in the history

  2. sss_client/common.c: comment amended 

    Amended comment for `make_safe_fd()`
    @alexey-tikhonov @jhrozek
    alexey-tikhonov authored and jhrozek committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    7b59fa8 View commit details
    Browse the repository at this point in the history

  3. sss_client/nss_services.c: indentation fixed 

    Fixed indentation (tabs -> spaces) to follow "Coding guidelines"
    @alexey-tikhonov @jhrozek
    alexey-tikhonov authored and jhrozek committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    fcae9cc View commit details
    Browse the repository at this point in the history

  4. sss_client/nss_services.c: fixed incorrect mutex usage 

    Fixed "unlock mutex without previous lock" bug
    @alexey-tikhonov @jhrozek
    alexey-tikhonov authored and jhrozek committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    7ca6270 View commit details
    Browse the repository at this point in the history

  5. sss_client: global unexported symbols made static

    @alexey-tikhonov @jhrozek
    alexey-tikhonov authored and jhrozek committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    ddf4d1f View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2019

  1. sss_client/common.c: fix Coverity issue 

    Usage of
strncpy(nssaddr.sun_path, socket_name, sizeof(nssaddr.sun_path))
1) confuses Coverity due to 3rd argument being equal to sizeof(1st)
2) again zeroes previously zeroed buffer
So replaced with strcpy()
This should be safe due to existing check of sizes.

Resolves:
https://pagure.io/SSSD/sssd/issue/3841
    @alexey-tikhonov @jhrozek
    alexey-tikhonov authored and jhrozek committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    f957168 View commit details
    Browse the repository at this point in the history

  2. sss_client/common.c: fix off-by-one error in sizes check 

    `sizeof(nssaddr.sun_path)` being equal to `strlen(socket_name) + 1`
should be fine, not error.
    @alexey-tikhonov @jhrozek
    alexey-tikhonov authored and jhrozek committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    e5764a0 View commit details
    Browse the repository at this point in the history

  3. SSSCTL: user-checks does not show custom attributes 

    "sssctl user-checks" also query the IFP interface of sssd. The problem
is, that this command only displays POSIX user attrs, no matter if we
configured the InfoPipe for additional user attributes.

With this patch additional attributes are also printed out.

Resolves:
https://pagure.io/SSSD/sssd/issue/3866
    @thalman @jhrozek
    thalman authored and jhrozek committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    d3af76d View commit details
    Browse the repository at this point in the history
Loading