SDAP: fix discarded-qualifiers warning in split_extra_attr()

alexey-tikhonov · alexey-tikhonov · commit 086a52e5d1c0 · 2026-02-23T15:19:50.000Z
Make sep `const char *` since it only holds a strchr() result
from a const input string and is used for pointer arithmetic.

Implementation-By: Claude Code (Opus 4.6)
Reviewed-by: Tomáš Halman &lt;thalman@redhat.com&gt;
diff --git a/src/providers/ldap/sdap.c b/src/providers/ldap/sdap.c
@@ -96,7 +96,7 @@ static errno_t split_extra_attr(TALLOC_CTX *mem_ctx,
 {
     char *ldap_attr;
     char *sysdb_attr;
-    char *sep;
+    const char *sep;
 
     sep = strchr(conf_attr, ':');
     if (sep == NULL) {

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ static errno_t split_extra_attr(TALLOC_CTX *mem_ctx,`
`96`	`96`	`{`
`97`	`97`	`char *ldap_attr;`
`98`	`98`	`char *sysdb_attr;`
`99`		`- char *sep;`
	`99`	`+ const char *sep;`
`100`	`100`
`101`	`101`	`sep = strchr(conf_attr, ':');`
`102`	`102`	`if (sep == NULL) {`