Fix #613 MCSAT curried function model reconstruction#614
Open
Fix #613 MCSAT curried function model reconstruction#614
Conversation
daniel-raffler
added a commit
to sosy-lab/java-smt
that referenced
this pull request
Mar 13, 2026
Segfaults have been fixed by SRI-CSL/yices2#614
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #613.
This fixes an MCSAT model-construction bug on curried functions such as
array(1)(7), which could reachsatand then crash while building/printing the model. The UF model builder now reconstructs nested function values recursively from the MCSAT trail instead of treating function-valued intermediates as first-order defaults.This PR also adds a focused API regression test for the reported curried-function case, fixes an MCSAT-specific lambda error-path mismatch in the SMT2 preprocessor, and extends the regression harness with a
tests/regress/bothbucket that runs selected higher-order/array regressions under both--mcsatand--dpllt.